Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue handling of some special characters (like #) #60

Closed
dege13 opened this issue Oct 16, 2023 · 3 comments · Fixed by #61
Closed

Issue handling of some special characters (like #) #60

dege13 opened this issue Oct 16, 2023 · 3 comments · Fixed by #61

Comments

@dege13
Copy link

dege13 commented Oct 16, 2023

Proposed solution:
"#" should be converted to %23

Browser error text:
Error loading: file:///X:/Video%20Projects/Uploaded/2022-11-26%2021-38-26%20-%20Maxell%20#1%20-%20Huntington.mp4

Console error:
obs-random-videos.html:240 Error loading: file:///X:/Video%20Projects/Uploaded/2022-11-26%2021-38-26%20-%20Maxell%20#1%20-%20Huntington.mp4 errorFunction @ obs-random-videos.html:240 error (async) (anonymous) @ obs-random-videos.html:219

Screenshot:
Capture

@dege13
Copy link
Author

dege13 commented Oct 17, 2023

Acter further testing, I actually think this is an issue in the video player in Chrome (and Firefox). I did a quick test and found without your code at all, the video player fails with files with a "#" character in the file name.

<source src="X:\Video Projects\Uploaded\2022-11-26 21-38-26 - Maxell #1 - Fresh Step.mp4" type="video/mp4">
results in a failure.

<source src="X:\Video Projects\Uploaded\2022-11-26 21-38-26 - Maxell 1 - Discover.mp4" type="video/mp4">
plays fine

However, if I manually convert the "#" in the file name to a %23, it plays, like this.
<source src="X:\Video Projects\Uploaded\2022-11-26 21-38-26 - Maxell %231 - Fresh Step.mp4" type="video/mp4">
But this only fixes Chrome, and not Firefox.

For now, I will rename my hundreds of videos using this naming format.

@jaredcat
Copy link
Member

jaredcat commented Oct 29, 2023

@dege13 can you test out https://github.com/UpDownLeftDie/obs-random-videos/releases/tag/v3.4.4 and let me know if you see any improvement?

As for it not working in FireFox, that's interesting but not real relevant as OBS uses chromium for browser sources. So as long as it works for that specific version of chrome that's all we need.

@jaredcat jaredcat reopened this Oct 30, 2023
@dege13
Copy link
Author

dege13 commented Oct 30, 2023

@jaredkotoff Works great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants