Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI: Remove GlyphIcons (Bootstrap 3) and Replace With... #85

Open
jeremy-farrance opened this issue Sep 21, 2023 · 1 comment
Open

SI: Remove GlyphIcons (Bootstrap 3) and Replace With... #85

jeremy-farrance opened this issue Sep 21, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed sponsors welcome The effort required would make a sponsor the ideal approach to closing this issue.

Comments

@jeremy-farrance
Copy link
Sponsor Contributor

jeremy-farrance commented Sep 21, 2023

Is your feature request related to a problem?

The Icons in use are coming from Bootstrap 3 GlyphIcons. They are pretty old, they look outdated, and it will help take a step towards the likely near-future removal of Bootstrap 3 altogether.

Describe the solution you'd like

Replace them with a standalone open source icon set. The two most likely candidates are:

  • Bootstrap Icons - standalone project with no ties/dependencies to Bootstrap (4, 5, etc)
  • Google Icons - standalone (with more modern Symbols option)

Describe alternatives you've considered

There are other free options like FontAwesome and HeroIcons (and many others). But the two above seem to align most with this project's long term needs (IMHO - JRF).

Additional context

I can probably contribute a PR with a complete solution for this change. However, I wanted to get feedback.

  • Is this a good step forward or just an unnecessary change?
  • Some voting or guidance on the icon set to switch to; Google vs. Bootstrap? Or should another alternative be considered?

A visual?

Here is what the Google Icons would look like. The Actions column shows replacements of the 3 existing Glyphicons. The Icons under Status are showing when the user is super, is unauthorized, and is deleted. The Icon to the right of Username header is showing the current sort direction (though not working).

image

@WillStrohl
Copy link
Contributor

I love this update. Yes, please feel free to do a PR if you'd like. Thanks, @jeremy-farrance! 💪🏽

@WillStrohl WillStrohl added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed sponsors welcome The effort required would make a sponsor the ideal approach to closing this issue. labels Sep 23, 2023
@WillStrohl WillStrohl changed the title Remove GlyphIcons (Bootstrap 3) and Replace With... SI: Remove GlyphIcons (Bootstrap 3) and Replace With... Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed sponsors welcome The effort required would make a sponsor the ideal approach to closing this issue.
Projects
None yet
Development

No branches or pull requests

2 participants