-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle shared dependencies being required by server dependencies #80
Handle shared dependencies being required by server dependencies #80
Conversation
Note to self - when developing on Windows make sure that the encoding of files isn't set to UTF16-LE 😬 |
At this point two integration tests were added:
|
rather than it's request realm
When activating a dependency, always use the origin realm (i.e. inherited realm from state) instead of it's declared realm
In a nutshell (I think):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work on this! I have no comments and agree with all your changes. Lockfiles are now generated correctly (#130) so this is ready to be merged! I have updated the snap files to respect these full lockfiles correctly. Thanks for putting this together and sorry it took so long to merge.
Not really the best title to this PR. Fixes #66