Add support for Elasticsearch 6 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=========================================
- Coverage 72.11% 69.52% -2.6%
=========================================
Files 3 3
Lines 538 502 -36
=========================================
- Hits 388 349 -39
- Misses 150 153 +3
Continue to review full report at Codecov.
|
|
ayyy this worked!
|
|
@austin3dickey thanks for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Elasticsearch 6.x!!! This has been long overdue (Elasticsearch 6.0.0 came out in 7 months ago)...sorry for the delay.
The most relevant change (for this package) in ES 6.x was the strict enforcement of content type on HTTP requests. TL;DR previously ES just figured it out automagically for you, which made debugging kind of hard and was also a security risk. ES6 is now more verbose and will break more often when you don't tell the service what content-type is being exchanged in requests.
For more, see this blog post from Elastic's engineering team on the issue: https://www.elastic.co/blog/strict-content-type-checking-for-elasticsearch-rest-requests.
addresses #43