From f5d464c8c1caebc71fab59d15eaa3c3622d71393 Mon Sep 17 00:00:00 2001 From: Udayshankar Ravikumar Date: Sun, 8 Sep 2024 17:58:49 +0530 Subject: [PATCH] Whoops. - It seems the DELETE method does not exist in the Gemini API's endpoints. - I've also fixed the bug with empty response confirmations. --- Documentation/index.md | 1 - README.md | 1 - .../Runtime/Scripts/Managers/GeminiManager.cs | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Documentation/index.md b/Documentation/index.md index 37ab9dc..f1da8de 100644 --- a/Documentation/index.md +++ b/Documentation/index.md @@ -98,7 +98,6 @@ Do not use preview versions (i.e. versions that end with "-preview") for product - ✔️ `list` method - ✔️ `operations` endpoint\* - - ✔️ `delete` method - ✔️ `list` method 🧪 - Using the v1beta API diff --git a/README.md b/README.md index 43abebe..e2d1b88 100644 --- a/README.md +++ b/README.md @@ -92,7 +92,6 @@ Do not use preview versions (i.e. versions that end with "-preview") for product - [x] `list` method - [x] `operations` endpoint\* - - [x] `delete` method - [x] `list` method 🧪 - Using the v1beta API diff --git a/UGemini/Packages/com.uralstech.ugemini/Runtime/Scripts/Managers/GeminiManager.cs b/UGemini/Packages/com.uralstech.ugemini/Runtime/Scripts/Managers/GeminiManager.cs index 673150f..eb89bd8 100644 --- a/UGemini/Packages/com.uralstech.ugemini/Runtime/Scripts/Managers/GeminiManager.cs +++ b/UGemini/Packages/com.uralstech.ugemini/Runtime/Scripts/Managers/GeminiManager.cs @@ -302,7 +302,7 @@ private TResponse ConfirmResponse(UnityWebRequest request) /// Thrown if the response was not empty. private void ConfirmResponse(UnityWebRequest request) { - if (!string.IsNullOrEmpty(request.downloadHandler?.text) || request.downloadHandler.text.Trim() == EmptyJsonObject) + if (!string.IsNullOrEmpty(request.downloadHandler?.text) && request.downloadHandler.text.Trim() != EmptyJsonObject) { Debug.LogError($"Failed to confirm successful API response:\n{request.downloadHandler?.text}"); throw new GeminiResponseParsingException(request);