Add feature to directly open files with IrodsPath #241
Conversation
| if self.collection_exists(): | ||
| raise ValueError("Cannot open collection, only data objects can be opened.") | ||
| # Create the data object if it does not exist. | ||
| if mode == "w" and not self.dataobject_exists(): |
There was a problem hiding this comment.
Can we add that existing object cannot be opened in write mode. It would be very useful as it led to inconsistencies when I tried that previously!!!
Can we maybe add an else which throws a message that an existing object can only be opened in read mode?
There was a problem hiding this comment.
Or maybe we need to test a bit more for the writing existing data objects.
There was a problem hiding this comment.
That seems inconsistent with how opening files works though. Doesn't it make more sense that the data object gets removed and then opened for writing?
There was a problem hiding this comment.
@chStaiger I have tested, and writing to a data object that already exists is possible and will simply overwrite it. I think this is how it should be done. Let me know if you agree, then you can perhaps approve and merge.
There was a problem hiding this comment.
Yes, I think I opened the data object in "append" mode. And that led to problems. So all fine with me.
This will make it more natural for users to open files directly from the IrodsPath, instead of needing to go through the PRC.
Fixes #170
TODO: