-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to IrodsPath, rename function #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestions, otherwise thanks for picking this one up!
ibridges/tickets.py
Outdated
elif check: | ||
raise KeyError(f"Cannot delete ticket: ticket '{ticket}' does not exist (anymore).") | ||
|
||
def update_tickets(self) -> list[TicketData]: | ||
def list_tickets(self) -> list[TicketData]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want to rename it? Now it looks kind of strange to simply call the method without using its contents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found update_tickets
confusing. We are not updating them but pull the information again from the iRODS server. So it is more a list
or refresh
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, then let's go with refresh_tickets if you agree?
Co-authored-by: qubixes <44498096+qubixes@users.noreply.github.com>
Rename the listing function for tickets
Switch to IrodsPath