bits 12-15 should return 0s, not 1s. checked with trapthem pad on rea…

…l c64. fixes bug #2064 git-svn-id: https://svn.code.sf.net/p/vice-emu/code/trunk@45325 379a1393-f5fb-40a0-bcee-ef074d9b53f7
VICE-Team · Aug 31, 2024 · c43678c · c43678c
1 parent df7c474
commit c43678c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/vice/src/joyport/ninja_snespad.c b/vice/src/joyport/ninja_snespad.c
@@ -178,11 +178,11 @@ static uint8_t snespad_read(int port)
         case SNESPAD_BIT_13_1:
         case SNESPAD_BIT_14_1:
         case SNESPAD_BIT_15_1:
-            /* part of the snes sequence, but unused, return 1 on each line */
-            retval = 7;
+            /* part of the snes sequence, but unused, return 0 on each line */
+            retval = 0;
             break;
         case SNESPAD_EOS:
-            retval = 0;
+            retval = 7;
             break;
         default:
             retval = 1;

diff --git a/vice/src/joyport/trapthem_snespad.c b/vice/src/joyport/trapthem_snespad.c
@@ -132,10 +132,11 @@ static uint8_t snespad_read(int port)
         case SNESPAD_BIT_13_1:
         case SNESPAD_BIT_14_1:
         case SNESPAD_BIT_15_1:
-            retval = 4;
+            /* part of the snes sequence, but unused, return 0 on each line */
+            retval = 0;
             break;
         case SNESPAD_EOS:
-            retval = 0;
+            retval = 4;
             break;
         default:
             retval = 1;

diff --git a/vice/src/userport/userport_petscii_snespad.c b/vice/src/userport/userport_petscii_snespad.c
@@ -213,7 +213,8 @@ static uint8_t userport_snespad_read_pbx(uint8_t orig)
         case SNESPAD_BIT_13_1:
         case SNESPAD_BIT_14_1:
         case SNESPAD_BIT_15_1:
-            retval = 1;
+            /* part of the snes sequence, but unused, return 0 on each line */
+            retval = 0;
             break;
         case SNESPAD_EOS:
             retval = 1;