Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auth loops #3087

Merged
merged 5 commits into from
Jun 6, 2023
Merged

fix auth loops #3087

merged 5 commits into from
Jun 6, 2023

Conversation

craig8
Copy link
Contributor

@craig8 craig8 commented Jun 5, 2023

Description

This PR includes updates to the logger as well as improvements in the way the watchers work. Files that were modified also were reformatted, though I tried to keep the reformatting as different commits than the true changes.

Fixes #3307

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

After this PR startup sequence of VOLTTRON (-v)

image

Before PR startup sequence VOLTTRON (-v)

image

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Tested on my branch and develop using python 3.8 on ubuntu 20.04

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

_log.debug(
"Connecting using: %s", get_fq_identity(self.identity)
)
_log.debug("Connecting using: %s", get_fq_identity(self.identity))

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (password)](1) as clear text. This expression logs [sensitive data (password)](1) as clear text.
_log.debug(
"Connecting using: %s", get_fq_identity(self.identity)
)
_log.debug("Connecting using: %s", get_fq_identity(self.identity))

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (password)](1) as clear text. This expression logs [sensitive data (password)](1) as clear text.
url_address=info.rmq_address, ssl_auth=True)
remote_rmq_user = get_fq_identity(fqid_local,
info.instance_name)
_log.debug("REMOTE RMQ USER IS: %s", remote_rmq_user)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (password)](1) as clear text. This expression logs [sensitive data (password)](1) as clear text.
@shwethanidd shwethanidd merged commit 3aae340 into VOLTTRON:develop Jun 6, 2023
@craig8 craig8 deleted the 3077_fix_auth_loops branch June 6, 2023 16:36
@craig8 craig8 linked an issue Jun 6, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite log printing at startup
2 participants