Setup this repo as a Unity Package #3
Closed
nvandessel
started this conversation in
Ideas and Feature Requests
Replies: 2 comments 3 replies
-
Thank you for your detailed feedback. I completely agree and hope we will switch to a package structure as soon as possible. |
Beta Was this translation helpful? Give feedback.
2 replies
-
Complete with #16 merged! |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi! First off very excited to see this project on GitHub! Congrats on the release! It's very exciting to see contributions like this to the VR developer community, especially at this caliber. I have a small suggestion that I think could provide significant benefit to both maintainers and end-users of this framework.
Problem Hypothesis:
Right now it seems like the repository is pulled straight from the Assets directory of a project and possibly maintained by tracking within the scope of that directory.
For end-users/developers, this makes it difficult to integrate the framework into their existing projects as it could conflict with existing file/folder structure and would involve a process of cloning the repository directly into their project (not recommended!) or possibly cloning and then copying the files into a sub-directory within the project (also not good as you've now lost Version Control!). Both of these are not ideal and have different issues surrounding them.
For maintainers and contributors, it provides a barrier of entry for a couple of reasons. They would either need to have 1) a dedicated empty project that is not in version control to contain this repo, or 2) possibly utilizing something like git submodules which has its own set of quirks. This makes meaningful open source contributions more difficult as there are additional layers of complexity to simply see your changes compile and test/validate they work.
Proposed Solution:
Restructure the repository to follow Unity Package hierarchy (defined here).
End users can then simply add this incredible framework to their project via the Unity Package Manager directly using a git URL or through a scoped registry. This is how the current Valve OpenXR Plugin is delivered and makes the import and setup a seamless experience. I would recommend checking out their Structure section from within the README to see their various delivery mechanisms.
For maintainers they can now have this repository sit outside of any existing project or repo, and add it as a local package into their project/s via the Unity Package Manager. Changes made to the framework will now be cleanly tracked and open source contributions through Pull Request will be a breeze!
Look forward to exploring the framework more and seeing it grow!
Beta Was this translation helpful? Give feedback.
All reactions