Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoVim update causes vim commands to no longer work on VSCode. #1751

Closed
elmlish opened this issue May 25, 2017 · 27 comments
Closed

NeoVim update causes vim commands to no longer work on VSCode. #1751

elmlish opened this issue May 25, 2017 · 27 comments

Comments

@elmlish
Copy link

elmlish commented May 25, 2017

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Environment:

  • VSCode Version: 1.12.2
  • VsCodeVim Version: v0.8.0
  • OS: Windows 10

What happened: Updated Vim in VSCode. Got a warning that I had to enable NeoVim by changing the settings. I added "vim.enableNeovim": true, to the User Settings, also tried setting it in the settings.json. After I did this, no vim related actions would work. I couldn't navigate with the jk keys, I couldn't use and : commands, I couldn't search, and I couldn't edit any files.
I uninstalled vim from VSCode and reinstalled and the same situation arose.

What did you expect to happen: Vim would work and be fabulous.

How to reproduce it: install Vim, Vim fails and files are uneditable. Though, I'm guessing it's more complicated than that.

@Chillee
Copy link
Member

Chillee commented May 25, 2017

Hmm, maybe I could have made things more clear in the docs. Enabling neovim is an optional setting, and you also need to set the path to the executable in order for it to work. If you disable the setting again, it should work fine.

@Chillee
Copy link
Member

Chillee commented May 25, 2017

Also, #1735 (comment)

@iliekturtles
Copy link

Possibly related: Ctrl-v, select range, c is causing VsCodeVim to stop working since the latest update. Cursor changes to input mode but no VsCodeVim keyboard commands are effective until VSCode is restarted.

@Chillee
Copy link
Member

Chillee commented May 26, 2017

@iliekturtles You mean you enter visual block mode, select some stuff, and then press c?

@iliekturtles
Copy link

@Chillee Correct. Regular visual mode works fine.

@awsp
Copy link

awsp commented May 26, 2017

OS: Elementary OS (Ubuntu 16.04)
VSCode Version: 1.12.2

Looks like it does not work at all on HTML files entirely even I disable the neovim.
All keys are halted.
One more thing is when using j j or any keybinding will trigger the modified flag so VSCode thinks the file is modified even no changes was made.

Anyway to downgrade it? Needed to get my work done by today ...No VIM = No Coding :D

@Chillee
Copy link
Member

Chillee commented May 26, 2017

@awsp It doesn't work even if VSCodeVim is disabled?

@awsp
Copy link

awsp commented May 26, 2017

@Chillee sorry typo, I meant NeoVim
"vim.enableNeovim": false

@Chillee
Copy link
Member

Chillee commented May 26, 2017

@awsp Have you restarted VSCode after toggling it off?

@awsp
Copy link

awsp commented May 26, 2017

@Chillee Yes, many times.

@awsp
Copy link

awsp commented May 26, 2017

@Chillee
FYI: VSCode debugger shows no error message at all.

@Chillee
Copy link
Member

Chillee commented May 26, 2017

And it only doesn't work on HTML files?

@awsp
Copy link

awsp commented May 26, 2017

HTML: not work at all
JSON: intermittently
JS: intermittently

haven't tried other file types yet.

I believe once it fails, keys on all files stop working.

@Chillee
Copy link
Member

Chillee commented May 26, 2017

@awsp We might decide to rollback this release, but for now, you can follow the instructions here: https://stackoverflow.com/questions/37071388/how-to-install-vscode-extensions-offline

There's a .vsix download here: https://github.com/VSCodeVim/Vim/releases/tag/v0.6.20

@Chillee
Copy link
Member

Chillee commented May 26, 2017

@iliekturtles I can't seem to reproduce the issue. Could you post your settings?

@awsp
Copy link

awsp commented May 26, 2017

@Chillee
I tried to install 0.6.20, other files are working except HTML files, strange...
I need to check if it conflicts with other plugins I installed.

Switched to Windows VSCode, using 0.7.1, working perfectly.
Elementary OS was using 0.7.1 as well before keys are halted.

@Chillee
Copy link
Member

Chillee commented May 26, 2017

@awsp That's bizarre... Any other updates recently?

@awsp
Copy link

awsp commented May 26, 2017

@Chillee
It turns out the extension I just installed, HTML Class Suggestions, conflicts with this extension. Uninstalled that, then now it works under 0.8.0.

But the problem for modified flag still exists for escape remapping. Tho, might not necessary because of 0.8.0 release.
Sorry about that man.

Best

@Chillee
Copy link
Member

Chillee commented May 26, 2017

Thanks! I suspect the issues with the modified flag have always been present. Could you open up an issue for that when you have some time?

@iliekturtles
Copy link

@Chillee I isolated the issue down to the following settings. Full settings at https://github.com/iliekturtles/dotfiles/blob/master/settings.json.

    "vim.useSystemClipboard": true,
    "vim.otherModesKeyBindingsNonRecursive": [
        { "before": ["c"], "after": ["\"", "\"", "c"] },
    ],

`

@Chillee
Copy link
Member

Chillee commented May 26, 2017

@iliekturtles Thanks! Got it to repro.

@awsp
Copy link

awsp commented May 26, 2017

@Chillee
Sure. Will do :D

@Chillee
Copy link
Member

Chillee commented May 26, 2017

@iliekturtles Tracking your issue here: #1758

@elmlish
Copy link
Author

elmlish commented May 26, 2017

Thank you @Chillee
I didn't understand that neovim was something I had to install separately. Once I did that, everything was snazzy.

@Chillee
Copy link
Member

Chillee commented May 26, 2017

@elmlish Yep we could have done a better job documenting the new setting :) Glad to hear it's worked out for you now.

@Chillee
Copy link
Member

Chillee commented May 27, 2017

I'm going to close this issue, as the main issue that opened up this thread has been resolved.

@Chillee Chillee closed this as completed May 27, 2017
@fikisipi
Copy link

fikisipi commented Oct 28, 2017

I'm having the same problem, except I have the vim.neovimPath set correctly to /usr/bin/nvim (which is a valid nvim executable with the correct permissions).

  • Neovim version: 0.2.0-2
  • VSCode version: 1.17.2
  • VSCodeVim version: 0.10.2
  • OS: GNU/Linux x64

The dev console doesn't contain any errors, the VSCodeVim extension is loaded properly, but I can't leave NORMAL mode (none of the keys work, neither hjkl, or i) unless I disable the neovim option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants