Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.86.0 #1798

Closed
4 of 6 tasks
daiyam opened this issue Feb 1, 2024 · 26 comments
Closed
4 of 6 tasks

v1.86.0 #1798

daiyam opened this issue Feb 1, 2024 · 26 comments

Comments

@daiyam
Copy link
Member

daiyam commented Feb 1, 2024

Hi all,

It will take few days to iron out the next version 1.86.0 to additional testing so I resolve the pitfalls of the previous versions:

I will look into:

I'm planning to release it on next Monday.

Edit: check fixed issues

@daiyam daiyam pinned this issue Feb 1, 2024
@llv22
Copy link

llv22 commented Feb 2, 2024

@daiyam does this newly released 1.86.0 support macOS 10.13.6? I don't want to upgraded my macOS system as need to support eGPU of nvidia 1080i. Thanks for your clarification and efforts.

@daiyam
Copy link
Member Author

daiyam commented Feb 2, 2024

The 1.86.0 uses:

  • Electron: 27.2.3
  • Chromium: 118.0.5993.159

Based on https://www.electronjs.org/blog/electron-27-0, it won't work on 10.13 and 10.14.

@daiyam
Copy link
Member Author

daiyam commented Feb 4, 2024

1.86.0 is also dropping RHEL-7 and Ubuntu-18...
I think it's mainly due to glibc which I ran into with the 1.85.x... (which require node-18)

@llv22
Copy link

llv22 commented Feb 6, 2024

@daiyam it seems that I need another computer ... ^-^

@daiyam
Copy link
Member Author

daiyam commented Feb 6, 2024

@llv22 We might not drop RHEL-7 and Ubuntu-18, just we need some testing...

@daiyam
Copy link
Member Author

daiyam commented Feb 6, 2024

For 1.86.x an Linux, I'm reverting to node-16 but it the latest version which is able to be built with node-16. I was able to revert the places which were requiring node-18.
I've planning to release that hybrid on the Insiders version so people can test it before sending to all.

The 1.87 has dependencies which required node-18...

@daiyam
Copy link
Member Author

daiyam commented Feb 7, 2024

The Insiders version is avaliable at: https://github.com/VSCodium/vscodium-insiders/releases/tag/1.86.0.24038-insider

On 5.4.0-150-generic 18.04.1-Ubuntu:

  • .deb is working
  • .AppImage is working
  • REH is also working but the following libraries have the wrong node version:
    • node_modules/node-pty/build/Release/pty.node (no terminal...)
    • node_modules/@vscode/spdlog/build/Release/spdlog.node

Still working on it...

@llv22
Copy link

llv22 commented Feb 7, 2024

1.86.0 is also dropping RHEL-7 and Ubuntu-18... I think it's mainly due to glibc which I ran into with the 1.85.x... (which require node-18)

@daiyam. One interesting thing from my side is my macOS 10.13.6 actually supports node 18 and chromium 123.0.6275.0. My question is it possible to build vs code on macOS 10.13.6 with those necessary components?

@daiyam
Copy link
Member Author

daiyam commented Feb 7, 2024

macOS and Windows are built with node-18 since 1.82.
On Linux, I only moved to node-18 on 1.85 which caused a bunch of issues.

But your issue is with Electron-27 which doesn't support the 10.13 as per my previous comment.

@daiyam
Copy link
Member Author

daiyam commented Feb 8, 2024

1.86.0.24039-insider is available with a working REH (server running on Ubuntu-18)

I have disabled the snap because I can build it on local machine but not in CI... It will be good if someone can look into because I'm about of patience about it...
The difference with the previous build is that the snap was only build on CI with already published .deb but since I needed to test it, I made changes to build on local and also moved to core20...

Can somebody test it and tell me if it's working for them or not, thx!

@GreyXor
Copy link

GreyXor commented Feb 9, 2024

1.86.0.24039-insider is available with a working REH (server running on Ubuntu-18)

I have disabled the snap because I can build it on local machine but not in CI... It will be good if someone can look into because I'm about of patience about it... The difference with the previous build is that the snap was only build on CI with already published .deb but since I needed to test it, I made changes to build on local and also moved to core20...

Can somebody test it and tell me if it's working for them or not, thx!

Hello, it's working good for me (archlinux, sway) --ozone-platform-hint=auto

@shellheim
Copy link

Any updates on the release?

@daiyam
Copy link
Member Author

daiyam commented Feb 17, 2024

1.86.2.24048-insider is available

  • The client version (UI) is using node-v18 and doesn't work on Centos-7 and Ubuntu-18
  • The server version (REH) is using node-v16 and works on Centos-7 and Ubuntu-18

When the client version uses node-v16, it works on Ubuntu-18 (unknown on Centos-7).
But few dependencies are not matched on Ubuntu-18

dpkg: dependency problems prevent configuration of codium-insiders:
 codium-insiders depends on libgssapi-krb5-2 (>= 1.17); however:
  Version of libgssapi-krb5-2:amd64 on system is 1.16-2ubuntu0.4.
 codium-insiders depends on libxkbfile1 (>= 1:1.1.0); however:
  Version of libxkbfile1:amd64 on system is 1:1.0.9-2.

Should I switch the UI to node-v16 (every linux will be affected)? Or stop the support for Ubuntu-18 and Centos-7?
I will test node-v16 for UI in the next Insiders version.

I will look into building node-v18 with glibc-2.17 for platforms other than x64.

@shellheim
Copy link

I will test node-v16 for UI in the next Insiders version.

So, 1.86 of vscodium won't work on Ubuntu 18? It doesn't affect me personally so I don't mind. Good luck with the release and thanks for the work as always!

@daiyam
Copy link
Member Author

daiyam commented Feb 20, 2024

Just an update, I'm able to compile VSCodium to run on Centos-7 and Ubuntu-18 for both the IDE and the server version. But, not at the same time. So I need to rewrite the linux workflow.

Here a question for the Linux folks, would it be better to have 2 versions of the IDE with:

  • glibc2.17 and node16
  • glibc2.29 and node18

@llv22
Copy link

llv22 commented Feb 20, 2024

@daiyam I found https://github.com/blueboxd/chromium-legacy/releases/tag/1260910 with the support of macOS 10.13.6. Is it possible to build electronjs using this chromium built on macOS 10.13.6?

@shellheim
Copy link

@daiyam That's sounds excessive for both you and package maintainers. Are you sure you want to maintain 2 versions of vscodium? Having two packages might be a little confusing. Vscode seems to have a workaround in 1.86.1 According to the PM they have simply allowed vscode to connect to OSes they don't support for 12 more months. Why not just do that?

@shellheim
Copy link

It'll ease the workload on you.

@kotlinFan
Copy link

kotlinFan commented Feb 21, 2024

@daiyam thank you for your great work!
I think there is no need to waste time supporting TOO old distros. Centos-7 and Ubuntu-18 are not even previous LTS, they are obsolete by now.
Just do your best to publish the release without big delays from the upstream please.

@daiyam
Copy link
Member Author

daiyam commented Feb 22, 2024

VSCodium 1.86.2.24053 is out.

@shellheim
Copy link

Thanks for the hard work, and you still managed to support the Centos 7 and Ubuntu! You are amazing!

@xili-h
Copy link

xili-h commented Feb 24, 2024

I would like to have a server version that supports CentOS-7, but I can see it becoming increasingly difficult as time goes on. I switched to VSCodium because VSCode is dropping support for older distributions. As a graduate student in computational physics, I often encounter HPCs still running on CentOS-7. In fact, out of the six HPCs I use, only one is not running on CentOS-7.

@daiyam
Copy link
Member Author

daiyam commented Feb 24, 2024

@xili-h There are 2 versions of servers:

  • REH which provides remote server access with SSH
  • Web which offers a web UI

We currently only provide the REH version (which is compatible with Centos7 as VSCode (expect for the v1.86.0))

@xili-h
Copy link

xili-h commented Feb 25, 2024

Is there any chance that there will be a CentOS-7 supported REH server in the future?

@daiyam
Copy link
Member Author

daiyam commented Feb 25, 2024

@xili-h VSCodium REH 1.86.2 supports CentOS-7

@daiyam
Copy link
Member Author

daiyam commented Feb 26, 2024

I've moved the unchecked issues for the next major release #1815

@daiyam daiyam closed this as completed Feb 26, 2024
@daiyam daiyam unpinned this issue Feb 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants