Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown linting is not working #30

Closed
MarcoIeni opened this issue Jan 24, 2021 · 4 comments · Fixed by #31
Closed

Markdown linting is not working #30

MarcoIeni opened this issue Jan 24, 2021 · 4 comments · Fixed by #31
Labels
bug Something isn't working upstream We are waiting for a fix in an external dependency

Comments

@MarcoIeni
Copy link
Member

Bug description

If you take a look at actions, for example here you can see that markdown lint doesn't work, since the usage page is showed.

Screenshots

image

Additional context

The args field is not parsed correctly.
I will try to work on a fix.

@MarcoIeni MarcoIeni added the bug Something isn't working label Jan 24, 2021
@MarcoIeni
Copy link
Member Author

Asked support here

@stevenguh
Copy link
Member

stevenguh commented Jan 24, 2021

Have you tried the ignore parameter like the following?

name: Continuous Integration

on:
  push:
    branches: [master, vspacecode-next, which-key-next]
  pull_request:

jobs:
  markdown-lint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - name: Lint all files recursively
        uses: avto-dev/markdown-lint@v1
        with:
          config: '.markdownlint.yaml'
          ignore: 'node_modules docs/default-keybindings.md'
          args: '**/*.md'

I quickly looked up that gh action repo, it seems like the parameter ignore is just appending --ignore with string to markdown-cli in a docker.

@MarcoIeni
Copy link
Member Author

yes, it should be like you are saying, but there is a bug, because you have to repeat the --ignore flag for each file.
This is addressed in avto-dev/markdown-lint#12 so let's wait that they merge it.

@stevenguh
Copy link
Member

That's awesome!

@MarcoIeni MarcoIeni added the upstream We are waiting for a fix in an external dependency label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream We are waiting for a fix in an external dependency
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants