log_deprecated_pkg: fix compilation issues with Cadence tools #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's time to remove this deprecated stuff altogether now that we're about to make a new major release |
|
@LarsAsplund, agree. However, we have two major changes coming up:
I think that we might want to release v4.6.0 after 1, and v5.0.0 after 2. We, might deprecate stuff between those. Alternativaly, we could bump to v5.0.0, but then maybe we should go to v6.0.0 to be semver compliant. That is because, strictly, reworking the VCs in a backwards incompatible way is ok, as long as those are in Beta. However, deprecations and submoduling forces a major version bump. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks a commit from #684, which is required according to #728.
/cc @powARman @rodrigomelo9