Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version requires Typescript 5.6 which current LTS of angular (v18.2.7) does not support #1137

Closed
nb-midwestern opened this issue Oct 7, 2024 · 2 comments · Fixed by #1138
Milestone

Comments

@nb-midwestern
Copy link

nb-midwestern commented Oct 7, 2024

Bug Report or Feature Request (mark with an x)
- [ ] Regression (a behavior that used to work and stopped working in a new release)
- [x] Bug report -> please search issues before submitting
- [ ] Feature request
- [ ] Documentation issue or request
└─┬ ng2-pdf-viewer@10.3.1
  └── pdfjs-dist@4.7.76

See mozilla/pdf.js#18867 for more info

Typescript version changed in this release https://github.com/mozilla/pdf.js/releases/tag/v4.7.76

@nb-midwestern nb-midwestern changed the title Latest version requires Typescript 5.6 which current LTS of angular does not support Latest version requires Typescript 5.6 which current LTS of angular (v18.2.7) does not support Oct 7, 2024
@VadimDez VadimDez added this to the 10.3.2 milestone Oct 7, 2024
@selangley
Copy link

@VadimDez
I found this issue after getting 'ng build' errors in my Angular 18 app with the latest 10.4 version installed.

Perhaps the install documentation could be updated to indicate that Angular 18 users should install the 10.3.x version and not the 10.4 version?

@shamoon
Copy link
Contributor

shamoon commented Dec 4, 2024

Ah this is my fault, this is true. I completely forgot about this, sorry.

I guess question is how to proceed, either bump the requirements of this package to be Angular ≥19 or downgrade pdfjs for now (again).

See #1161 (though defer to VD of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants