Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pdfjs-dist to v4.6.82 #1139

Closed
SaschaSchwarz opened this issue Oct 8, 2024 · 2 comments · Fixed by #1140
Closed

Update pdfjs-dist to v4.6.82 #1139

SaschaSchwarz opened this issue Oct 8, 2024 · 2 comments · Fixed by #1140
Milestone

Comments

@SaschaSchwarz
Copy link

Bug Report or Feature Request (mark with an x)
- [x] Regression (a behavior that used to work and stopped working in a new release)
- [ ] Bug report -> please search issues before submitting
- [x] Feature request
- [ ] Documentation issue or request

The dependency on TS 5.6 was introduced in pdfjs-dist v4.7.76. Which led to the changes in #1138.

However, the most recent version <4.7.76 is v4.6.82.

@studioromeo
Copy link
Contributor

Good call. I imagine it shouldn't be locked to a specific version rather track semver otherwise we will continuously miss out on fixes from pdfjs upstream. ~ would be the appropriate choice here https://github.com/npm/node-semver#tilde-ranges-123-12-1 which allows patch level changes but denies minor.

@shamoon
Copy link
Contributor

shamoon commented Oct 8, 2024

I don’t believe they backfill releases so I don’t think there will be any minor versions < 4.7 so no point in ~ but you’re right I could’ve taken the opportunity to update to 4.6. I was more focused on un-breaking things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants