Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pdfjs-dist dependency to the latest version for better compatibility #1148

Closed
PatrickFrantzen opened this issue Nov 28, 2024 · 3 comments · Fixed by #1149
Closed

Update pdfjs-dist dependency to the latest version for better compatibility #1148

PatrickFrantzen opened this issue Nov 28, 2024 · 3 comments · Fixed by #1149

Comments

@PatrickFrantzen
Copy link

PatrickFrantzen commented Nov 28, 2024

Bug Report or Feature Request (mark with an x)
- [ ] Regression (a behavior that used to work and stopped working in a new release)
- [ ] Bug report -> please search issues before submitting
- [ ] Feature request
- [ ] Documentation issue or request
- [X ] Change request

Hi,

I’m using ng2-pdf-viewer version 10.3.4, which currently relies on pdfjs-dist version 4.6.82. However, this version of pdfjs-dist has rendering issues with images in certain PDFs.

Issue Details:
In a PDF containing a company logo, icons, and text data, the following problems occur when displayed using ng2-pdf-viewer in the latest Firefox browser:

The company logo and icons are not rendered.
Other elements, such as text and scale bars, display correctly.
The same rendering issue occurs when using older versions of the Firefox browser to open the PDF. However, when using the current Version of Firefox in its latest version, the images (logo and icons) are displayed correctly.

Proposed Solution:
Please update the pdfjs-dist dependency to version 4.8.69 or higher to ensure compatibility with Firefox and improve image rendering reliability.

Thank you for maintaining this project!

Best regards,
Patrick

@shamoon
Copy link
Contributor

shamoon commented Nov 28, 2024

This is a change request not a bug.

Unfortunately, the newest version of pdfjs breaks some stuff here so not just a simple package update.

@PatrickFrantzen
Copy link
Author

Hi, thanks for the response.
We updated the version of pdfjs-dist in the ng2-pdf-viewer locally in our project and only had to change one type definition and the pdf viewer just runs fine. We only use the pdf-viewer to display our files, maybe therefore no breaking changes occur.

@shamoon
Copy link
Contributor

shamoon commented Nov 29, 2024

Think I got it sorted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants