Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many tracks unavailable #19

Open
anotherstuart opened this issue Dec 9, 2022 · 3 comments
Open

Many tracks unavailable #19

anotherstuart opened this issue Dec 9, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@anotherstuart
Copy link

Hi

Thanks for your work; I have got the plugin up and running on osmc on my pi.

There seem to be very many tracks not available/skipped I'm wondering if this is a country rights issue. Are the requests made in line with the guidance here https://stackoverflow.com/questions/16958029/deezer-apsi-example-of-non-streamable-song-for-country-limitation

Or am I getting the rights of some random country, not my own?

Thanks

@Valentin271 Valentin271 added the good first issue Good for newcomers label Dec 13, 2022
@Valentin271
Copy link
Owner

Hello,

It is possible that many tracks are unavailable in your country, though the same tracks should be playable on DeezerKodi and official Deezer Apps.
Notice playable, more tracks might be visible than on official Deezer Apps

According to the link you provided, you should be getting the rights for your Deezer account country.

@anotherstuart
Copy link
Author

Hi, sorry this has taken so loooong for me to pick up and test again... there are definitely a large number of songs that are not played on the DeezerKodi plugin on my RPi compared to if I play the same list of songs on my phone. These are skipped, rather than it being a limited list.

I have had another look through possible causes and I wonder if it is something to do with the plugin treating itself as "Smart TV"? I am testing the list against using my phone (mostly) and a windows PC (sometimes) I never / almost never get skipped songs on ither of these two.

On the plus side, this is mildly annoying - but doesn't stop it being a great plugin.

If you can think of any specific tests I can do to pin this down please let me know.

Cheers

Stuart

@david-morris
Copy link

david-morris commented Mar 3, 2023

OK, I've confirmed that in this addon, Julie London's Cry Me A River causes a crash, but it plays on my phone. I'm in Germany.

So it's not just a matter of many tracks being unavailable. It's also a matter of the plugin crashing Kodi (which ... shouldn't be possible but OK, python is not the greatest language for embedding) and not being able to see which tracks are unplayable. To me, the following steps would make sense:

  • unavailable tracks should be skipped (don't crash Kodi)
  • (config options?) remember and hide/gray out unplayable tracks

Would that make sense in one PR or should we split this into two issues?
P.S. hey, are we checking the readable field of the track object?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants