Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of emotion #126

Closed
stefanoruth opened this issue May 12, 2020 · 1 comment · Fixed by #127
Closed

Removal of emotion #126

stefanoruth opened this issue May 12, 2020 · 1 comment · Fixed by #127

Comments

@stefanoruth
Copy link
Contributor

Hi, would you be interested in a pr for the removal of emotions?

The main reason behind this would be got get a smaller bundlesize.

Right now its on 12.5 kb

And the main reason for this is emotion.

I would propose a pr for the removel of emotion, and maybe a solution with inline scroped style tags, if you are open for a pr?

@ValentinH
Copy link
Owner

Hi!

Indeed, emotion represents the biggest part of the library and I'm not happy with it. 😞

I decided to use CSS-in-JS because I didn't want to ask everyone to include a css file. This is a common issue with every libraries that need to set some CSS rules.

I doubt that you can support all existing styles with only plain style tags (because of pseudo-elements) but if you find a way, I could consider a PR.

I could also consider switching to plain css that would need to be imported.

@ValentinH ValentinH linked a pull request May 12, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants