Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lenient dependency on tslib #534

Closed
aqeelat opened this issue Apr 30, 2024 · 4 comments · Fixed by #536
Closed

Allow lenient dependency on tslib #534

aqeelat opened this issue Apr 30, 2024 · 4 comments · Fixed by #536
Labels
released This issue/pull request has been released.

Comments

@aqeelat
Copy link
Contributor

aqeelat commented Apr 30, 2024

tslib version in package.json is 2.0.1. Is there a specific reason why you're only allowing that version? Why not use ^2.0.1?

It's not causing me trouble but I was auditing my yarn.lock and I noticed that I have two versions of tslib installed.

@ValentinH
Copy link
Owner

No, I don't see any reason for this. Would you like doing a PR?

@aqeelat
Copy link
Contributor Author

aqeelat commented May 2, 2024

Hi @ValentinH. Thank you for the prompt response. I'll open the PR soon.
I also see some other dev dependencies that are outdated. Maybe you'd want to look at them.

Screenshot 2024-05-02 at 12 26 47 PM

@ValentinH
Copy link
Owner

Thanks for the PR. I'll review it shortly.

Regarding outdated dev deps, I'm aware of them but it's hard to keep up with all of them. I'm really focusing on non-dev deps as they are the ones that matter for people using this lib. Dev deps are implementation details that only matter to contributors.

Copy link

github-actions bot commented May 6, 2024

🚀 Issue was released in v5.0.7 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants