[GoldSource] Texture overflow: GL_MAXTEXTURES crash #2234

metita · 2019-04-24T00:59:02Z

Sometimes when you are on a server with a lot of textures (I guess this is the reason based on the error code) and you keep switching between servers, your client will crash randomly. I can't really tell how to reproduce it so if someone has extra info would be amazing.

metita · 2019-04-25T20:02:03Z

This is a common issue on a lot of mod servers when switching between servers continuously, if someone got the original output on when this crash occurs, would help a lot.

SamVanheer · 2019-04-25T22:37:08Z

There are a maximum of 4800 textures that can be loaded. Normally textures are unloaded when the client starts preparing to load a new map. It looks like this part works fine.

Edit: everything below here is wrong, see comment below.

The part that doesn't is the code that reuses texture entries that were freed:

while ( HIBYTE(v12->servercount) & 0x80 )
{
  if ( !v9 )
    v9 = v12;
  ++v13;
  ++v12;
  if ( v13 >= v11 )
    goto LABEL_10;
}

//Other stuff that is ignored

LABEL_10:
if ( !v9 )
{
    v9 = &gltextures[numgltextures++];
    if ( numgltextures >= 4800 )
      Sys_Error("Texture Overflow: MAX_GLTEXTURES");
}

This is from GL_LoadTexture2. It translates to this:

gltexture_t* pSlot = nullptr;

for( int i = 0; i < numgltextures; ++i )
{
    if( gltextures[ i ].servercount >= 0 )
        break;

    if( !pSlot  )
        pSlot  = &gltextures[ i ];
}

//Other stuff that is ignored

if ( !pSlot )
{
    pSlot = &gltextures[numgltextures++];
    if ( numgltextures >= 4800 )
      Sys_Error("Texture Overflow: MAX_GLTEXTURES");
}

This code is supposed to find the first free entry (servercount < 0), but it instead stops searching when it encounters a single texture in use.

As a result GL_LoadTexture2 will almost never reuse freed entries and will keep allocating new entries until it runs out, resulting in the fatal error.

To fix this, the loop needs to be changed to this:

for( int i = 0; i < numgltextures; ++i )
{
    if( gltextures[ i ].servercount >= 0 )
        continue;

    if( !pSlot  )
        pSlot  = &gltextures[ i ];
}

Now it will skip entries in use and correctly reuse free entries.

@mikela-valve This should be fairly simple to fix and test.

metita · 2019-04-25T22:43:38Z

Thanks @SamVanheer appreciated your work.

@kisak-valve fix proposed? Thanks.

SamVanheer · 2019-04-25T23:04:51Z

Sorry, i got this wrong. There's an outer loop that ensures it iterates over each texture.

I did find what i think is the problem: in GL_LoadTexture2 the servercount variable is set depending on the texture type:

if ( textureType == GLT_WORLD )
{
  slot->servercount = gHostSpawnCount;
}
else
{
  slot->servercount = 0;
}

And in GL_UnloadTextures:

if ( pTexture->servercount > 0 && pTexture->servercount != gHostSpawnCount )

All textures other than the world (map textures) are never unloaded. An easy fix is to always use gHostSpawnCount and let all textures unload, but then there's the risk of unloading textures that are only loaded once (e.g. Draw_PicFromWad).

GLT_SYSTEM and GLT_DECAL texture types definitely shouldn't be unloaded, it looks like all others are resources that are loaded once per map. Maybe allowing all of these to be unloaded is the safest bet:

GLT_STUDIO
GLT_WORLD
GLT_SPRITE

It looks like hud sprites are always GLT_HUDSPRITE so they should be safe.

mikela-valve · 2019-05-16T16:58:08Z

I'm going to delay this until after the next release as I'd like it to be in a beta that has fewer changes in it to make it easier to notice if any issues arise from unloading these other texture types.

metita · 2019-10-23T20:22:03Z

@mikela-valve Now that we got a clean beta and the latest update got released officially would like you to take a look at this issue because is a very common one on modded servers.

dystopm · 2019-11-17T20:08:18Z

Any news about this? It's a bit annoying nowadays

zorkenJB · 2020-01-19T18:28:59Z

@mikela-valve can you fix this?

TheDoctor0 · 2020-07-18T16:29:06Z

I would also gladly see this fix applied as it is a common issue nowadays.

dystopm · 2020-07-19T03:23:54Z

Nothing? @mikela-valve it is a frequent error this days, will this ever be considerated on a future release?

metita · 2020-08-03T21:27:12Z

@mikela-valve Sorry for bothering you with this one, is there a chance for this issue to be somehow added into the beta now that there are almost 0 issues with it? It is a annoying bug that is pretty common nowadays.

Roccoxx · 2020-08-04T01:46:04Z

considerating we're getting updates for the game, can you please take a look at this issue? @mikela-valve thanks in advance

Maria22s · 2020-08-04T01:54:45Z

This is very annoying, can you take a look at it please? @mikela-valve

SamVanheer · 2020-08-04T09:16:03Z

You don't all have to get his attention, one person calling for him is more than enough. And the issue is already assigned to the next release milestone so it's a priority issue anyway.

orinasa · 2020-10-15T21:47:36Z

When will it be? after 5 years? or will not at all. @mikela-valve

P.S Do you have an idea how to fix it? Texture overflow: GL_MAXTEXTURES.

dystopm · 2020-10-15T22:01:12Z

This is a high priority issue which is ruining actual gameplay, and also an excuse for players to use pirate software (to fix it) because most servers are modded nowadays with lots of resources, bringing a high chance to suffer this crash - @mikela-valve may I ask again, is there a chance to get this fixed?

cyb3rm4n · 2020-11-13T23:42:37Z

Agreed with @PM32, got this error on most of servers (i have my own modded server and my client suffers with this error)

zorkenJB · 2020-11-14T09:47:31Z

@mikela-valve can you please fix it? is not that hard On Saturday, November 14, 2020, 01:42:51 AM GMT+2, Alexander Zhukov <notifications@github.com> wrote: Agreed with @PM32, got this error on most of servers (i have my own modded server and my client suffers with this error) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Maxi605 · 2020-11-14T19:16:33Z

@mikela-valve can you please fix it? is not that hard On Saturday, November 14, 2020, 01:42:51 AM GMT+2, Alexander Zhukov notifications@github.com wrote: Agreed with @PM32, got this error on most of servers (i have my own modded server and my client suffers with this error) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Is not about difficulty, he doesn't have time to work on goldsrc.

orinasa · 2020-11-16T04:42:27Z

@mikela-valve can you please fix it? is not that hard On Saturday, November 14, 2020, 01:42:51 AM GMT+2, Alexander Zhukov notifications@github.com wrote: Agreed with @PM32, got this error on most of servers (i have my own modded server and my client suffers with this error) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.
Is not about difficulty, he doesn't have time to work on goldsrc.

15 minutes work. and you say he doesn't have time to work? Lol...

SamVanheer · 2020-11-16T10:20:55Z

Supporting a 22 year old game is about as low priority as it gets, and chances are the source code isn't even accessible remotely so they can't work on it until the pandemic is under control. All you can do is be patient.

s1lentq · 2020-11-20T17:47:55Z

Sorry, i got this wrong. There's an outer loop that ensures it iterates over each texture.

I did find what i think is the problem: in GL_LoadTexture2 the servercount variable is set depending on the texture type:
if ( textureType == GLT_WORLD )
{
  slot->servercount = gHostSpawnCount;
}
else
{
  slot->servercount = 0;
}
And in GL_UnloadTextures:
if ( pTexture->servercount > 0 && pTexture->servercount != gHostSpawnCount )
All textures other than the world (map textures) are never unloaded. An easy fix is to always use gHostSpawnCount and let all textures unload, but then there's the risk of unloading textures that are only loaded once (e.g. Draw_PicFromWad).

GLT_SYSTEM and GLT_DECAL texture types definitely shouldn't be unloaded, it looks like all others are resources that are loaded once per map. Maybe allowing all of these to be unloaded is the safest bet:

GLT_STUDIO

GLT_WORLD

GLT_SPRITE

It looks like hud sprites are always GLT_HUDSPRITE so they should be safe.

@Solokiller IMHO, it looks like the issue is that the numgltextures global counter never decreases, and also textures potentially can be unloaded from the middle of the gltexture_t gltextures[4800] without shifting elements

SamVanheer · 2020-11-20T17:55:21Z

True, it doesn't seem to ever decrement that variable. However it does reuse texture slots that were unloaded so the error should only occur if all 4800 slots are in use at the same time. If the error occurs after a certain amount of time rather than when loading a particular map or other assets then it isn't clearing those slots correctly.

Matiarguello · 2021-08-04T13:01:20Z

three years later, without news, we also provide the code with the solution ... they just have to implement and test it.

hajimura · 2021-08-04T13:14:25Z

@MatiasEsf, because nobody cares more about this game

lexzor · 2022-05-30T19:46:46Z

@mikela-valve up?

huihuangex · 2024-10-06T20:05:52Z

anyone fix it？

metita changed the title ~~[GoldSource] GL_MAXTEXTURES crash.~~ [GoldSource] Texture overflow: GL_MAXTEXTURES crash Apr 24, 2019

mikela-valve self-assigned this Apr 25, 2019

mikela-valve added the Fix proposed label Apr 25, 2019

mikela-valve added this to the Next Release milestone Apr 25, 2019

mikela-valve modified the milestones: Next Release, Future Release May 16, 2019

mikela-valve modified the milestones: Future Release, Next Release Oct 28, 2019

kisak-valve mentioned this issue Nov 8, 2019

[CS1.6] Texture overflow (v8308) #2763

Closed

mikela-valve modified the milestones: Next Release, ToDo Aug 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GoldSource] Texture overflow: GL_MAXTEXTURES crash #2234

[GoldSource] Texture overflow: GL_MAXTEXTURES crash #2234

metita commented Apr 24, 2019

metita commented Apr 25, 2019 •

edited

Loading

SamVanheer commented Apr 25, 2019 •

edited

Loading

metita commented Apr 25, 2019

SamVanheer commented Apr 25, 2019 •

edited

Loading

mikela-valve commented May 16, 2019

metita commented Oct 23, 2019 •

edited

Loading

dystopm commented Nov 17, 2019

zorkenJB commented Jan 19, 2020

TheDoctor0 commented Jul 18, 2020

dystopm commented Jul 19, 2020

metita commented Aug 3, 2020

Roccoxx commented Aug 4, 2020

Maria22s commented Aug 4, 2020

SamVanheer commented Aug 4, 2020

orinasa commented Oct 15, 2020 •

edited

Loading

dystopm commented Oct 15, 2020

cyb3rm4n commented Nov 13, 2020

zorkenJB commented Nov 14, 2020 via email

Maxi605 commented Nov 14, 2020

orinasa commented Nov 16, 2020 •

edited

Loading

SamVanheer commented Nov 16, 2020

s1lentq commented Nov 20, 2020 •

edited

Loading

SamVanheer commented Nov 20, 2020 •

edited

Loading

Matiarguello commented Aug 4, 2021

hajimura commented Aug 4, 2021

lexzor commented May 30, 2022

huihuangex commented Oct 6, 2024

[GoldSource] Texture overflow: GL_MAXTEXTURES crash #2234

[GoldSource] Texture overflow: GL_MAXTEXTURES crash #2234

Comments

metita commented Apr 24, 2019

metita commented Apr 25, 2019 • edited Loading

SamVanheer commented Apr 25, 2019 • edited Loading

metita commented Apr 25, 2019

SamVanheer commented Apr 25, 2019 • edited Loading

mikela-valve commented May 16, 2019

metita commented Oct 23, 2019 • edited Loading

dystopm commented Nov 17, 2019

zorkenJB commented Jan 19, 2020

TheDoctor0 commented Jul 18, 2020

dystopm commented Jul 19, 2020

metita commented Aug 3, 2020

Roccoxx commented Aug 4, 2020

Maria22s commented Aug 4, 2020

SamVanheer commented Aug 4, 2020

orinasa commented Oct 15, 2020 • edited Loading

dystopm commented Oct 15, 2020

cyb3rm4n commented Nov 13, 2020

zorkenJB commented Nov 14, 2020 via email

Maxi605 commented Nov 14, 2020

orinasa commented Nov 16, 2020 • edited Loading

SamVanheer commented Nov 16, 2020

s1lentq commented Nov 20, 2020 • edited Loading

SamVanheer commented Nov 20, 2020 • edited Loading

Matiarguello commented Aug 4, 2021

hajimura commented Aug 4, 2021

lexzor commented May 30, 2022

huihuangex commented Oct 6, 2024

metita commented Apr 25, 2019 •

edited

Loading

SamVanheer commented Apr 25, 2019 •

edited

Loading

SamVanheer commented Apr 25, 2019 •

edited

Loading

metita commented Oct 23, 2019 •

edited

Loading

orinasa commented Oct 15, 2020 •

edited

Loading

orinasa commented Nov 16, 2020 •

edited

Loading

s1lentq commented Nov 20, 2020 •

edited

Loading

SamVanheer commented Nov 20, 2020 •

edited

Loading