Counter-Strike new update on Linux crashes when open scoreboard #3551

khanghugo · 2023-11-22T18:29:02Z

Here is the log after joining a game and open scoreboard.

Error:/home/khang/.local/share/Steam/steamapps/common/Half-Life/.so: cannot open shared object file: No such file or directory
DemoPlayer::Init: couldn't get engine interface.

ERROR! System::AddModule: couldn't initialize module (null).

Can't "cmd", not connected

Unknown command from unsafe location. Ignoring.

STEAM Auth Server

Playing Startup Videos...

AppActive: active
AppActive: active
AppActive: not active
AppActive: active
No detail texture mapping file: maps/crossfire_detail.txt

[S_API] SteamAPI_Init(): Loaded '/home/khang/.local/share/Steam/linux32/steamclient.so' OK.
CAppInfoCacheReadFromDiskThread took 17 milliseconds to initialize
dlmopen steamservice.so failed: steamservice.so: cannot open shared object file: No such file or directory
SteamInternal_SetMinidumpSteamID:  Caching Steam ID:  76561197960265728 [API loaded yes]
SteamInternal_SetMinidumpSteamID:  Setting Steam ID:  76561197960265728
Looking up breakpad interfaces from steamclient
Calling BreakpadMiniDumpSystemInit
SteamInternal_SetMinidumpSteamID:  Caching Steam ID:  76561197960265728 [API loaded yes]
SteamInternal_SetMinidumpSteamID:  Setting Steam ID:  76561197960265728
ERROR: ld.so: object '/home/khang/.local/share/Steam/ubuntu12_64/gameoverlayrenderer.so' from LD_PRELOAD cannot be preloaded (wrong ELF class: ELFCLASS64): ignored.
crash_20231122132703_14.dmp[12803]: Uploading dump (out-of-process)
/tmp/dumps/crash_20231122132703_14.dmp
crash_20231122132703_14.dmp[12803]: Finished uploading minidump (out-of-process): success = yes
crash_20231122132703_14.dmp[12803]: response: Discarded=1
crash_20231122132703_14.dmp[12803]: file ''/tmp/dumps/crash_20231122132703_14.dmp'', upload yes: ''Discarded=1''
pid 12803 != 12802, skipping destruction (fork without exec?)
/home/khang/.local/share/Steam/steamapps/common/Half-Life/hl.sh: line 83: 12722 Segmentation fault      (core dumped) ${DEBUGGER} "${GAMEROOT}"/${GAMEEXE} "$@"

The text was updated successfully, but these errors were encountered:

kisak-valve · 2023-11-22T19:48:36Z

Possibly related to #3502.

OlegAckbar · 2023-11-22T19:57:50Z

Can confirm this issue

ghost · 2023-11-22T20:26:26Z

Stack trace:

Program terminated with signal SIGSEGV, Segmentation fault.

warning: Section `.reg-xstate/189663' in core file too small.
#0  CCSClientScoreBoardDialog::UpdateTeamInfo (this=<optimized out>) at ../cstrike/cl_dll/VGUI/cstrikeclientscoreboard.cpp:577
Downloading source file /home/buildbot/buildslave/goldsrc_linux/build/GoldSrc/linux/../cstrike/cl_dll/VGUI/cstrikeclientscoreboard.cpp
577     ../cstrike/cl_dll/VGUI/cstrikeclientscoreboard.cpp: Directory not empty.                                                                                           
[Current thread is 1 (Thread 0xf766cb00 (LWP 189663))]
(gdb) info stack
#0  CCSClientScoreBoardDialog::UpdateTeamInfo (this=<optimized out>) at ../cstrike/cl_dll/VGUI/cstrikeclientscoreboard.cpp:577
#1  0xcf0369eb in CClientScoreBoardDialog::FillScoreBoard (this=0x951cab0) at ../vgui2/game_controls/ClientScoreBoardDialog.cpp:501
#2  CClientScoreBoardDialog::Update (this=this@entry=0x951cab0, servername=servername@entry=0xffa1504b " Player's Server", teamplay=teamplay@entry=true, 
    spectator=spectator@entry=false) at ../vgui2/game_controls/ClientScoreBoardDialog.cpp:168
#3  0xcef57682 in CCSClientScoreBoardDialog::Update (this=0x951cab0, servername=0xcf0afde4 <__g_CounterStrikeViewport_singleton+132> "Player's Server", 
    teamplay=true, spectator=false) at ../cstrike/cl_dll/VGUI/cstrikeclientscoreboard.cpp:274
#4  0xcf03f1c1 in TeamFortressViewport::OnTick (this=this@entry=0xcf0afd60 <__g_CounterStrikeViewport_singleton>)
    at ../vgui2/game_controls/vgui_TeamFortressViewport.cpp:690
#5  0xcef508a0 in CounterStrikeViewport::OnTick (this=0xcf0afd60 <__g_CounterStrikeViewport_singleton>) at ../cstrike/cl_dll/VGUI/counterstrikeviewport.cpp:770
#6  0xcef87a3d in CHud::UpdateClientData (this=this@entry=0xcf0b4900 <gHUD>, cdata=cdata@entry=0xffa15130, time=time@entry=3.81224442)
    at ../cstrike/cl_dll/hud_update.cpp:42
#7  0xcef70188 in HUD_UpdateClientData (pcldata=0xffa15130, flTime=3.81224442) at ../cstrike/cl_dll/cdll_int.cpp:484
#8  0xf4a9234d in ClientDLL_UpdateClientData () at ../engine/cdll_int.c:1186
#9  0xf49e2a55 in _Host_Frame (time=time@entry=2.6350001e-06) at ../engine/host.c:1414
#10 0xf49e2d38 in Host_Frame (time=2.6350001e-06, iState=1, stateInfo=stateInfo@entry=0xffa1524c) at ../engine/host.c:1549
#11 0xf4a13e24 in CEngine::Frame (this=0xf4c74ee0 <g_Engine>) at ../engine/sys_engine.cpp:245
#12 0xf4a10e84 in RunListenServer (instance=0x0, basedir=0x804d120 <szBaseDir> "~/.local/share/Steam/steamapps/common/Half-Life", 
    cmdline=0x8b39d00 "~/.local/share/Steam/steamapps/common/Half-Life/hl_linux -steam -game cstrike", 
    postRestartCmdLineArgs=0x804f260 <main::szNewCommandParams> "", launcherFactory=0x80497f0 <CreateInterface(char const*, int*)>, 
    filesystemFactory=0xf5d05450 <CreateInterface(char const*, int*)>) at ../engine/sys_dll2.cpp:968
#13 0x0804905b in main (argc=4, argv=0xffa154b4) at ../launcher/launcher.cpp:469

ShiroYasha456 · 2023-11-24T12:47:40Z

having the same issue myself

ByJumperX4 · 2023-11-25T05:44:06Z

Having the same problem on my end
flatpak steam, gentoo linux

ghost · 2023-11-27T01:52:39Z

confirming this issue myself too

Eoin-ONeill-Yokai · 2023-11-27T02:30:37Z

Can confirm this issue on Fedora linux.

eightyninetytwo · 2023-11-28T02:13:33Z

Confirming this issue on Linux Mint

Neonpk · 2023-11-28T10:26:25Z

I'm unable to reproduce. I've installed the latest version of HLDS 06:35:09 Nov 23 2023 (9891) joined the server and pressed key to open scoreboard and the server did not crash.

On ReHLDS in conjunction with REGAME-DLL and METAMOD-R everything works fine

drehak · 2023-11-28T15:15:41Z

Confirming on Arch (X11/i3, 64bit).

Neonpk · 2023-11-28T15:22:33Z

SteamDB shows that a test update was released today. (https://steamdb.info/app/10/history/)
Most likely, one of these days there will be a patch.

eightyninetytwo · 2023-11-28T15:29:45Z

SteamDB shows that a test update was released today. (https://steamdb.info/app/10/history/) Most likely, one of these days there will be a patch.

You're a legend, thanks for keeping everyone updated

jinetty · 2023-11-28T21:20:22Z

Confirming on Arch Linux (Plasma 5.27 Wayland/X11 Session)

flaphoschi · 2023-11-29T13:21:30Z

Confirmed (Archlinux, GNOME/WAYLAND, AMD RNDA2 running Kernel 6.2.2, Mesa 23.2.1).

@kisak-valve
Do you need beta-testers? I willing to test and report. As I see the current channel beta - beta is shipping the an old release, so this is not an option.

// edit
Todays update didn't fixed it.

bolokanar · 2023-11-29T19:16:18Z

Yep, still crashing after new update.

Neonpk · 2023-11-29T19:29:11Z

Yes, same thing.

Now I have debugged and the stack trace turned out to be similar to @stacksmash76.

Thread 1 "hl_linux" hit Breakpoint 1, CCSClientScoreBoardDialog::UpdateTeamInfo (this=0x8cb44f0) at ../cstrike/cl_dll/VGUI/cstrikeclientscoreboard.cpp:559 559 ../cstrike/cl_dll/VGUI/cstrikeclientscoreboard.cpp: No such file or directory.

SamVanheer · 2023-11-29T19:49:00Z

A quick look using IDA shows they're probably passing sizeof(bufname) to swprintf instead of ARRAYSIZE(bufname). Before the anniversary update this caused it to silently write past the end of the buffer which is on the stack, so random corruption issues occurred that probably went unnoticed since the overwritten memory was written to afterwards.

Now it uses _swprintf_chk which is responsible for shutting the game down due to said overflows: https://refspecs.linuxbase.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/baselib---swprintf-chk-1.html

There are a number of cases in various parts of the engine and the games where wide character string buffers have their size calculated using sizeof instead of ARRAYSIZE. Best to just check all of them and fix them all in one go, but that could break things in other ways. The buffer sizes need double checking and increasing where needed.

For reference: char is one byte in size so number of characters equals size in bytes, wchar_t's size is implementation-defined: 2 bytes on Windows and 4 bytes on Linux.

The buffer size is 6 characters so 6 * 4 is 24, which is what's being passed in.

Interestingly the first call does pass the correct size so it's inconsistently calculated.

fred0r · 2023-11-29T22:11:20Z

@kisak-valve
maybe take a look at https://github.com/mikkokko/csldr for some inspiration about FOV.

kisak-valve · 2023-11-29T23:04:02Z

Hello @fred0r, friendly reminder that I'm a moderator for Valve's issue trackers on Github, and not a game developer myself. I have no real insight into the game's code base beyond what's publicly available.

fred0r · 2023-11-30T04:50:33Z

@kisak-valve
sry - wasnt ment 'like that' :/
maybe you could file my url to some dev, beside giving him some context from this 'issue'.

andrzej-tech · 2023-11-30T10:46:14Z

+1
NAME="Pop!_OS"
VERSION="22.04 LTS"

Neonpk · 2023-11-30T15:15:20Z

In addition to the scoreboard.

I found another problem related to swprintf and __swprintf_chk, which was described by @SamVanheer.

When you join a server with a custom weapon slot and when you select the desired slot, the client crashes in the same way.
On the function call CHudVGUI2Print::VGUI2HudPrintArgs

Stack Trace:

*** buffer overflow detected ***: terminated

Thread 1 "hl_linux" received signal SIGABRT, Aborted.
0xf7fc7579 in __kernel_vsyscall ()
(gdb) bt
#0  0xf7fc7579 in __kernel_vsyscall ()
#1  0xf788ea17 in ?? () from /usr/lib32/libc.so.6
#2  0xf783b317 in raise () from /usr/lib32/libc.so.6
#3  0xf7822121 in abort () from /usr/lib32/libc.so.6
#4  0xf78231b6 in ?? () from /usr/lib32/libc.so.6
#5  0xf793be03 in __fortify_fail () from /usr/lib32/libc.so.6
#6  0xf793b7df in __chk_fail () from /usr/lib32/libc.so.6
#7  0xf793d075 in __swprintf_chk () from /usr/lib32/libc.so.6
#8  0xdaabd67f in swprintf (
    __fmt=0xffffa910 L"Mode: Normal (\xc1c0ddac\xec254472\xffffaa70", 
    __n=2048, __s=0xdabefa18 <gHUD+24856> L"Free Chase Cam")
    at /usr/include/i386-linux-gnu/bits/wchar2.h:292
#9  CHudVGUI2Print::VGUI2HudPrintArgs (this=0xdabef9fc <gHUD+24828>, 
    charMsg=charMsg@entry=0xdac04180 <CHudTextMessage::MsgFunc_TextMsg(char const*, int, void*)::szBuf> "Mode: Normal", 
    sstr1=sstr1@entry=0xdac04200 <CHudTextMessage::MsgFunc_TextMsg(char const*, int, void*)::szBuf+128> "", 
    sstr2=sstr2@entry=0xdac04280 <CHudTextMessage::MsgFunc_TextMsg(char const*, int, void*)::szBuf+256> "", 
    sstr3=sstr3@entry=0xdac04300 <CHudTextMessage::MsgFunc_TextMsg(char const*, int, void*)::szBuf+384> "", 
    sstr4=sstr4@entry=0xdac04380 <CHudTextMessage::MsgFunc_TextMsg(char const*, int, void*)::szBuf+512> "", x=x@entry=-1, y=378, r=r@entry=1, 
--Type <RET> for more, q to quit, c to continue without paging--
    g=g@entry=0.70599997, b=b@entry=0.118000001)
    at ../cstrike/cl_dll/hud_vgui2print.cpp:323

bolokanar · 2023-12-01T20:00:27Z

Exe build: 08:56:59 Dec 1 2023 (9899)
Still not working

fred0r · 2023-12-07T03:14:08Z

https://steamdb.info/app/10/history/
#21428111

/me keeps his fingers crossed

eightyninetytwo · 2023-12-07T03:29:30Z

https://steamdb.info/app/10/history/ #21428111

/me keeps his fingers crossed

Been keeping my fingers crossed for a month now lmao

peylight · 2023-12-08T07:51:50Z

I have the same problem.
It is not about server.
Even make New game on client can cause crash when Tab clicked.

6yntar05 · 2023-12-09T11:28:36Z

+1
ArchLinux

peylight · 2023-12-09T18:17:04Z

Even Condition Zero have the same problem.

bolokanar · 2023-12-10T14:54:25Z

Btw I think I found another bug...
Can somebody please confirm if it's crashing when you buy via vest; vesthelm from console or bind. Doesn't really matter.

Neonpk · 2023-12-10T15:22:45Z

@bolokanar

Everything is fine in New Game.

When you join a server with the metamod extension, it crashes due to the same error swprintf and __swprintf_chk

On a call to the same function: CHudVGUI2Print::VGUI2HudPrintArgs , which was described above.

bolokanar · 2023-12-10T17:49:24Z

@bolokanar

Everything is fine in New Game.

When you join a server with the metamod extension, it crashes due to the same error swprintf and __swprintf_chk

On a call to the same function: CHudVGUI2Print::VGUI2HudPrintArgs , which was described above.

Weird. On my end it crashes even in New game.
Anynody can point me to a resource to generate a trace?

Anyway, opened a new issue: #3701

kernel17 · 2023-12-10T21:40:41Z

+1
NixOS-Unstable

SamVanheer · 2023-12-10T21:42:54Z

There's no need to keep bumping this issue, the cause is known. It happens on Linux regardless of distro. Just wait until it's listed as fixed.

fir3-1ce · 2023-12-11T07:12:08Z

I just had it crash while using the buy menu. I don't know what triggered it. The scoreboard bug is there too

bolokanar · 2023-12-11T11:21:27Z

I just had it crash while using the buy menu. I don't know what triggered it. The scoreboard bug is there too

#3672

0Ky · 2023-12-12T17:27:50Z

Dec 12, 2023 update:
* Fixed an occasional crash when opening the scoreboard.

@khanghugo Can you retest again? I believe the recent update should have fixed this.

Neonpk · 2023-12-12T17:32:55Z

Yay.
🆒
😃
This is victory, but viewdemo command is still not fixed (the client crashes).

bt:

Error:/home/neonpk/.local/share/Steam/steamapps/common/Half-Life/.so: cannot open shared object file: No such file or directory
CDemoPlayerDialog::LoadModules: couldn't get engine interface.

viewdemo <demoname>: shows a demo


Thread 1 "hl_linux" received signal SIGSEGV, Segmentation fault.
0xda8d119f in CDemoPlayerDialog::ApplySchemeSettings (this=0xcb92160, 
    pScheme=0x8b4fb90) at ../GameUI/DemoPlayerDialog.cpp:139
139	../GameUI/DemoPlayerDialog.cpp: No such file or directory
(gdb) c
Continuing.

Thread 1 "hl_linux" received signal SIGSEGV, Segmentation fault.
0xda8d119f in CDemoPlayerDialog::ApplySchemeSettings (this=0xcb92160, 
    pScheme=0x8b4fb90) at ../GameUI/DemoPlayerDialog.cpp:139
139	in ../GameUI/DemoPlayerDialog.cpp
(gdb) bt
#0  0xda8d119f in CDemoPlayerDialog::ApplySchemeSettings (this=0xcb92160, 
    pScheme=0x8b4fb90) at ../GameUI/DemoPlayerDialog.cpp:139
#1  0xda947c43 in vgui2::Panel::PerformApplySchemeSettings (this=0xcb92160)
    at ../vgui2/controls/Panel.cpp:1871
#2  0xf5dc6524 in BaseUISurface::InternalSchemeSettingsTraverse (
    this=this@entry=0xf6545660 <g_BaseUISurface>, panel=panel@entry=146771344, 
    forceApplySchemeSettings=forceApplySchemeSettings@entry=false)
    at ../engine/vgui2/BaseUISurface.cpp:1379

bolokanar · 2023-12-12T18:52:52Z

Yep, it works on my end (finally)

] version 
Protocol version 48
Exe version 1.1.2.7/Stdio (cstrike)
Exe build: 23:26:01 Dec  9 2023 (9907)

flaphoschi · 2023-12-12T19:03:20Z

Confirm the fix. Thank you for fixing 🙂

App ID: 10
Build ID: 12934623

Protocol version 48
Exe version 1.1.2.7/Stdio (cstrike)
Exe build: 23:26:01 Dec  9 2023 (9907)

The wording with "occasional" is funny. I literally press Tab multiple times within a round.

khanghugo · 2023-12-12T19:36:05Z

Works for me.

flaphoschi · 2023-12-18T17:52:43Z

@kisak-valve I think you can close this issue 😉

khanghugo changed the title ~~Counter-Strike new update crashes when open scoreboard~~ Counter-Strike new update on Linux crashes when open scoreboard Nov 22, 2023

kisak-valve added Counter-Strike Linux labels Nov 22, 2023

Eoin-ONeill-Yokai mentioned this issue Nov 23, 2023

[CS] Counter Strike completely broken after 25th update #3553

Closed

flaphoschi mentioned this issue Nov 29, 2023

[HL25] CS Buffer Overflow when showing scoreboard #3627

Closed

kisak-valve mentioned this issue Dec 5, 2023

cs 1.6 crashes when I press the tab key #3682

Closed

kisak-valve mentioned this issue Dec 10, 2023

[Linux][CS] CS 1.6 crashes when pressing tab #3700

Closed

kisak-valve mentioned this issue Dec 11, 2023

[Deleted Scenes] crosshair element for AUG/SIG 552 reverts to Half-Life 'stubby crosshair' whenever zoomed #3704

Open

SamVanheer mentioned this issue Dec 11, 2023

[CS] [Linux] Crash when buying Kevlar+Helmet while already having Kevlar (and/or Helmet) #3672

Closed

kisak-valve added the Need Retest label Dec 12, 2023

khanghugo closed this as completed Dec 19, 2023

kisak-valve removed the Need Retest label Dec 19, 2023

0Ky mentioned this issue Jan 28, 2024

[Linux] [CS1.6] couldn't exec maps/de_dust2_load.cfg #3738

Open

0Ky mentioned this issue Aug 24, 2024

[CS 1.6] Linux viewdemo command makes the client to crash or auto close #3800

Closed

Counter-Strike new update on Linux crashes when open scoreboard #3551

Counter-Strike new update on Linux crashes when open scoreboard #3551

Comments

khanghugo commented Nov 22, 2023

kisak-valve commented Nov 22, 2023

OlegAckbar commented Nov 22, 2023

ghost commented Nov 22, 2023

ShiroYasha456 commented Nov 24, 2023

ByJumperX4 commented Nov 25, 2023

ghost commented Nov 27, 2023

Eoin-ONeill-Yokai commented Nov 27, 2023

eightyninetytwo commented Nov 28, 2023

Neonpk commented Nov 28, 2023

drehak commented Nov 28, 2023

Neonpk commented Nov 28, 2023 • edited Loading

eightyninetytwo commented Nov 28, 2023

jinetty commented Nov 28, 2023

flaphoschi commented Nov 29, 2023 • edited Loading

bolokanar commented Nov 29, 2023

Neonpk commented Nov 29, 2023 • edited Loading

SamVanheer commented Nov 29, 2023

fred0r commented Nov 29, 2023

kisak-valve commented Nov 29, 2023

fred0r commented Nov 30, 2023

andrzej-tech commented Nov 30, 2023

Neonpk commented Nov 30, 2023 • edited Loading

bolokanar commented Dec 1, 2023

fred0r commented Dec 7, 2023

eightyninetytwo commented Dec 7, 2023

peylight commented Dec 8, 2023 • edited Loading

6yntar05 commented Dec 9, 2023

peylight commented Dec 9, 2023

bolokanar commented Dec 10, 2023

Neonpk commented Dec 10, 2023 • edited Loading

bolokanar commented Dec 10, 2023 • edited Loading

kernel17 commented Dec 10, 2023

SamVanheer commented Dec 10, 2023

fir3-1ce commented Dec 11, 2023

bolokanar commented Dec 11, 2023

0Ky commented Dec 12, 2023

Neonpk commented Dec 12, 2023 • edited Loading

bolokanar commented Dec 12, 2023

flaphoschi commented Dec 12, 2023

khanghugo commented Dec 12, 2023

flaphoschi commented Dec 18, 2023

Neonpk commented Nov 28, 2023 •

edited

Loading

flaphoschi commented Nov 29, 2023 •

edited

Loading

Neonpk commented Nov 29, 2023 •

edited

Loading

Neonpk commented Nov 30, 2023 •

edited

Loading

peylight commented Dec 8, 2023 •

edited

Loading

Neonpk commented Dec 10, 2023 •

edited

Loading

bolokanar commented Dec 10, 2023 •

edited

Loading

Neonpk commented Dec 12, 2023 •

edited

Loading