Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt ddraw-Rendering_Targets patch from staging #58

Open
tannisroot opened this issue Aug 3, 2019 · 3 comments
Open

Adopt ddraw-Rendering_Targets patch from staging #58

tannisroot opened this issue Aug 3, 2019 · 3 comments
Labels

Comments

@tannisroot
Copy link

Apparently, many old DX3-7 games rely on being able to create a rendering target in system memory rather than video memory, and mainline Wine does not support that. This patch from Staging solves this issue by creating the render target in video memory instead.
Some notable games that depend on this according to WineHQ: *The Sims, Zoo Tycoon, TOCA Touring Car Championship, Conquest: Frontier Wars (the latter is available on Steam and has a demo)
However, there might be many more games out there that depend this feature, there are just the ones that were reported to use it.
I can personally confirm that it works very well with The Sims and that game was stable for hours and hours.
The patch: https://github.com/wine-staging/wine-staging/tree/master/patches/ddraw-Rendering_Targets
The WineHQ issue: https://bugs.winehq.org/show_bug.cgi?id=34906

@aeikum
Copy link
Collaborator

aeikum commented Aug 5, 2019

Thanks for the suggestion. I've asked for some input from our d3d devs, will keep you posted.

@kisak-valve kisak-valve added the cw label Aug 12, 2019
@jqadev
Copy link

jqadev commented Jun 21, 2020

Any update on this patch? I can see that there is a silence in the WineHQ issue. Maybe you should create a PR here.

@aeikum
Copy link
Collaborator

aeikum commented May 14, 2021

This bug was fixed in upstream Wine, and those commits have been backported in Proton 6.3-4. Can you retest and confirm that it is fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants