Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABRoot doesn't check if package exists before removing it #193

Closed
VladShmi opened this issue Jan 8, 2024 · 5 comments
Closed

ABRoot doesn't check if package exists before removing it #193

VladShmi opened this issue Jan 8, 2024 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@VladShmi
Copy link

VladShmi commented Jan 8, 2024

VanillaOS Orchid Alpha build 100. ABRoot doesn't clear selection after reboot if not applied. For example I selected epiphany-browser (if it I select epiphany, it "removes" it successfully, but after reboot is still there) and gnome-totem (which doesn't exist) and ABRoot doesn't let me apply changes because of gnome-totem. I can't even upgrade or force an upgrade, because is still fails. But after reboot selection is still there, i only select epiphany-browser so now when i apply I have "... pkg add epiphany-browser gnome-totem epiphany-browser" so you can never change the status of system because is buged like that.

Clarification by Tau:
While abroot checks if a package exists when using pkg add, it doesn't do that on pkg remove. This causes abroot to fail when removing an nonexistent package.

Currently, when running abroot pkg apply or abroot upgrade, ABRoot will try to uninstall all packages the user specifies, even if they don't exist in the repos, which makes abroot fail.

Since ABRoot should be able to uninstall custom packages which are not in the repos it should probably just check if the packages are installed before uninstalling them.

This is a concern because if a package gets renamed or removed from the debian repos, automatic upgrades will fail and it needs user intervention, which is not ideal.

@taukakao
Copy link
Member

taukakao commented Jan 8, 2024

You shouldn't install software with ABRoot, just drivers.

And I don't quite get what you are saying, what exactly is failing when you do abroot upgrade -f ?

@VladShmi
Copy link
Author

VladShmi commented Jan 8, 2024

I want remove that software from system because for me is trash. When I do abroot upgrade, abroot upgrade -f or abroot pkg apply, everything fails, because like i said before "gnome-totem" doesn't exist

@taukakao
Copy link
Member

taukakao commented Jan 8, 2024

Those apps are installed via flatpak. Either use Gnome Software or the "flatpak --user " command to remove them.

@taukakao
Copy link
Member

taukakao commented Jan 8, 2024

Though this is indeed a bug. ABRoot should check if the package exists when removing.

To fix your abroot config, type in
host-spawn pkexec nano /etc/abroot/packages.remove
Remove the packages that are causing the issue and save the file.

@taukakao taukakao changed the title ABRoot not clearing selection and maybe not checking packages correctly ABRoot doesn't check if package exists before adding it to the removal list Jan 8, 2024
@taukakao taukakao added the bug Something isn't working label Jan 8, 2024
@taukakao taukakao self-assigned this Jan 8, 2024
@taukakao taukakao changed the title ABRoot doesn't check if package exists before adding it to the removal list ABRoot doesn't check if package exists before removing it Jan 8, 2024
@mirkobrombin mirkobrombin moved this to Todo in 2 - Orchid Apr 28, 2024
@mirkobrombin mirkobrombin added this to the 2-stable milestone Apr 28, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in 2 - Orchid Apr 28, 2024
@taukakao taukakao reopened this Apr 28, 2024
@taukakao taukakao moved this from Done to Todo in 2 - Orchid Apr 28, 2024
@mirkobrombin
Copy link
Member

Fixed by e5aa9f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants