ABRoot doesn't correctly delete old image

[taukakao]

This requires more testing, but ABRoot leaves behind an old image on every upgrade. This makes the storage folder (/var/lib/abroot/storage) run full very quickly.

I mean the issue has been around for a long time, it just didn't seem important enough to make an issue before.

[kbdharun]

Can confirm I have the same issue on a very old installation where storage gets full during abroot upgrade.

[taukakao]

@kbdharun
To fix an old installation affected by this, it's enough to just delete /var/lib/abroot/storage/*
ABRoot will then just download the newest image completely.

[taukakao]

So, after some experimentation:
ABRoot always leaves around an image for each root, which is probably desired to run package installs from each root. These have the tag localhost/abroot-[some-uuid]:latest

But ABRoot also leaves around the downloaded image on every upgrade, it has the tag: docker.io/library/abroot-[some-uuid]:latest

This bug should be fixable by just untagging the downloaded image.
Edit: it isn't that easy since the image is tagged multiple times.

[taukakao]

Ok, found a working solution. Just deleting the image with the correct digest works. Since ABRoot always creates a new image ontop of the downloaded one, this works. (It will not delete the layers, just the reference to the image.

[taukakao]

I will make a PR after some testing and polishing

[JonnyB247]

I can't get to /var/lib/abroot. Is it possible to escape the VSO shell?

[taukakao]

@JonnyB247
Yes, with host-shell. Also note that you have to use pkexec since sudo is not available on the host.