Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

falconn wrapper #20

Closed
VarIr opened this issue Aug 29, 2019 · 3 comments
Closed

falconn wrapper #20

VarIr opened this issue Aug 29, 2019 · 3 comments
Assignees
@VarIr
Labels
bug Something isn't working enhancement New feature or request

Comments

@VarIr
Copy link
Owner

VarIr commented Aug 29, 2019

Currently, there seems to be no way to create a valid scikit-learn-compatible wrapper for falconn, as its LSHindex cannot be pickled. This is an issue of falconn.

Possible solutions:

  • Wait for falconn pickle support (however, no ETA)
  • Switch to different LSH library
  • Add other ANN tools, be it LSH or not
@VarIr VarIr self-assigned this Aug 29, 2019
@VarIr VarIr mentioned this issue Aug 30, 2019
Merged
@VarIr
Copy link
Owner Author

VarIr commented Aug 30, 2019

The falconn.LSHindex could possibly be memmapped as done in #21.

@VarIr VarIr added bug Something isn't working enhancement New feature or request labels Aug 30, 2019
@VarIr
Copy link
Owner Author

VarIr commented Sep 2, 2019

There seems to be no adequate way to serialize/memmap the index. falconn development seems to have stalled, so it's unclear, whether this will be possible at all.

@VarIr
Copy link
Owner Author

VarIr commented Sep 6, 2019

puffinn can now pickle its index, so phasing out falconn is probably the way to go.

@VarIr VarIr mentioned this issue Sep 10, 2019
Merged
@VarIr VarIr closed this as completed Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VarIr VarIr

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VarIr