Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to click on bracket on HLIL #2549

Closed
elbiazo opened this issue Jul 12, 2021 · 2 comments
Closed

Ability to click on bracket on HLIL #2549

elbiazo opened this issue Jul 12, 2021 · 2 comments
Labels
Effort: Low Issue should take < 1 week Impact: Low Issue is a papercut or has a good, supported workaround State: Duplicate Issue is a duplicate of another issue Type: Enhancement Issue is a small enhancement to existing functionality

Comments

@elbiazo
Copy link

elbiazo commented Jul 12, 2021

Is your feature request related to a problem? Please describe.
Is it frustrating when you are reversing really big function and you don't really know where the end of bracket is.
image

Describe the solution you'd like
It would be nice if you can click on beginning of the bracket to see where end of the bracket is located at. Kind of like vscode
image
Ghidra also have feature where you can click on the beginning of bracket to follow the end of the bracket.
image

It would be also pretty sweet if there was an right click option to highlight all the code in between bracket.

Describe alternatives you've considered
Current method is to use comments or write a code to highlight addresses using the API.

@elbiazo elbiazo added the Type: Enhancement Issue is a small enhancement to existing functionality label Jul 12, 2021
@psifertex
Copy link
Member

Highlighting is unfortunately not likely to happen too soon as it is dependent on #1940 which requires a decent refactor of both the highlight system and/or how ILs are generated and serialized.

You could have a small gist which could implement an approximation using the native instructions at the appropriate addresses and "get_instruction_at" but it would be lossy and have some over and under-approximation. Let me know if you're interested in that and I can throw something together.

That said, the ability to more easily highlight and or navigate braces/code blocks is a good idea and worth leaving this issue open for.

@psifertex psifertex added Effort: Low Issue should take < 1 week Impact: Low Issue is a papercut or has a good, supported workaround labels Jul 12, 2021
@plafosse plafosse added the State: Duplicate Issue is a duplicate of another issue label Oct 1, 2021
@plafosse
Copy link
Member

plafosse commented Oct 1, 2021

Though this isn't exactly the same the solution we come up with will likely suffice for both: #1730

@plafosse plafosse closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Low Issue should take < 1 week Impact: Low Issue is a papercut or has a good, supported workaround State: Duplicate Issue is a duplicate of another issue Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants