Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SJIS String Analyzer Support #5668

Open
Yuvi-App opened this issue Jun 26, 2024 · 4 comments
Open

SJIS String Analyzer Support #5668

Yuvi-App opened this issue Jun 26, 2024 · 4 comments
Labels
Component: Core Issue needs changes to the core Effort: Medium Issue should take < 1 month Impact: Medium Issue is impactful with a bad, or no, workaround Type: Enhancement Issue is a small enhancement to existing functionality

Comments

@Yuvi-App
Copy link

What is the feature you'd like to have?
As one who works with mostly Japanese software, it would be a huge help if we had a way to have the String analyzer look for SJIS encode text instead of just ascii/utf8

Are any alternative solutions acceptable?
If its not possible, maybe a creating a plugin that could detect a variety of text encoding would be helpful.
As referring back and forth between a hex editor and BN can cause quite a headache.

@negasora
Copy link
Member

Related: #1334

@fuzyll
Copy link
Contributor

fuzyll commented Jun 26, 2024

Do you have any good examples of programs you're looking at that have SJIS-encoded text in them that you could attach? If/when we get around to this (and related issues), it would be great to have some test cases ready to go.

@Yuvi-App
Copy link
Author

Az15.zip
Here is an example exe, that contains quite a bit of SJIS starting at 0xDC000 (section .data)

Thanks all!

@xusheng6 xusheng6 added Type: Enhancement Issue is a small enhancement to existing functionality Component: Core Issue needs changes to the core Effort: Medium Issue should take < 1 month Impact: Medium Issue is impactful with a bad, or no, workaround labels Jul 2, 2024
@plafosse
Copy link
Member

plafosse commented Jul 2, 2024

One option to help you out would be writing a custom data renderer if these character strings can be converted to UTF-8. https://binary.ninja/2024/04/08/customizing-data-display.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Issue needs changes to the core Effort: Medium Issue should take < 1 month Impact: Medium Issue is impactful with a bad, or no, workaround Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

5 participants