Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open with Options dialog parses integer as decimal instead of hexadecimal by default #5682

Closed
xusheng6 opened this issue Jul 3, 2024 · 3 comments
Assignees
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality UI: Dialogs Issues with smaller dialogs

Comments

@xusheng6
Copy link
Member

xusheng6 commented Jul 3, 2024

When I type "1000" into the image base input, it is treated as 0x3e8, instead of 0x1000. I think we should parse the value as hex by default

Screenshot 2024-07-03 at 1 30 01 PM

@xusheng6 xusheng6 added Type: Enhancement Issue is a small enhancement to existing functionality Component: UI Issue needs changes to the user interface UI: Dialogs Issues with smaller dialogs Impact: Low Issue is a papercut or has a good, supported workaround Effort: Trivial Issue should take < 1 day labels Jul 8, 2024
@plafosse
Copy link
Member

plafosse commented Jul 9, 2024

Ideally here we should have instead of a QLineEdit we have our own BinjaNumericEdit control. This would automatically use ParseExpression on the backend and would also support automatic preview of the value to the right of the control.

@xusheng6 xusheng6 added this to the Frogstar milestone Jul 18, 2024
@xusheng6 xusheng6 self-assigned this Jul 18, 2024
@xusheng6
Copy link
Member Author

Well this is actually not easy to do -- the settings view have many other integer inputs that is better parsed as decimal

@bpotchik
Copy link
Member

Prepending 0x gives hex and without it you get a decimal. Regarding ParseExpression, it's not useful in this context as symbol information is not available. Since this is a common control used everywhere, I recommend not changing it's behavior.

@bpotchik bpotchik closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality UI: Dialogs Issues with smaller dialogs
Projects
None yet
Development

No branches or pull requests

3 participants