♻️ Rename LibRLP convenience functions #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vectorized
changed the title
|
Ack! Sorry for not responding here! What I meant to say was that after
solemnly considering the substantive merits of this change—i.e., checking
whether I was using the old API—I have come to the conclusion that it is
highly positive and I support this merge 100%!
…On Mon, Sep 16, 2024 at 3:28 AM Vectorized ***@***.***> wrote:
Merged #1070 <#1070> into main.
—
Reply to this email directly, view it on GitHub
<#1070 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAOONT3CKTH2ARKORC7PH3ZW2CDRAVCNFSM6AAAAABN6WV2GCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGI3DQMBQGE2DKNI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prepare for #1069.
This is breaking in internal API.
I feel
pis more natural than havingl,a,b, etc. if the struct name is different.@RogerPodacter
Letting this marinate first. Not urgent.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge snapshot?forge test?Pull requests with an incomplete checklist will be thrown out.