Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitrate and freqdev should be in kbps and kHz #23

Open
leobel96 opened this issue Apr 20, 2024 · 4 comments
Open

Bitrate and freqdev should be in kbps and kHz #23

leobel96 opened this issue Apr 20, 2024 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@leobel96
Copy link

From

io_home_fskrate.fsk.bitRate = 38400;

and
io_home_fskrate.fsk.freqDev = 19200;

the values should be 38.4 and 19.2

@Velocet Velocet self-assigned this Apr 26, 2024
@Velocet
Copy link
Owner

Velocet commented May 7, 2024

Why use a higher unit which needs floats instead of this simple define?

@Velocet Velocet added the wontfix This will not be worked on label May 7, 2024
@leobel96
Copy link
Author

leobel96 commented May 7, 2024

Define? I'm just saying that, from the Radiolib documentation:

struct FSKRate_t {
  /*! \brief FSK bit rate in kbps */
  float bitRate;
  
  /*! \brief FS frequency deviation in kHz*/
  float freqDev;
};

So, considering that you want 38.4kbps and 19.2kHz the values should be 38.4 and 19.2

@Velocet Velocet added bug Something isn't working good first issue Good for newcomers and removed wontfix This will not be worked on labels May 9, 2024
@Velocet
Copy link
Owner

Velocet commented May 9, 2024

You are totally right! Shame on me! Will be fixed with the next bigger code commit.

Thank you for finding and correcting me 👍🏻

@leobel96
Copy link
Author

No problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants