Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Node 12 #149

Closed
kriszyp opened this issue Apr 24, 2019 · 5 comments · Fixed by #150
Closed

Support for Node 12 #149

kriszyp opened this issue Apr 24, 2019 · 5 comments · Fixed by #150

Comments

@kriszyp
Copy link
Collaborator

kriszyp commented Apr 24, 2019

Add support for Node version 12, which I think is dependent on nodejs/nan#849.
@kriszyp kriszyp mentioned this issue May 3, 2019
Merged
@josephg
Copy link

josephg commented May 23, 2019

Nan supports node 12. In that thread @bnoordhuis says many issues are caused by old nan versions

@kriszyp
Copy link
Collaborator Author

kriszyp commented May 23, 2019

Yeah, this is fixed by #150, there is nothing wrong with Nan.

@innerop
Copy link

innerop commented May 30, 2019

Hi,

Thinking of trying this library. Is this still an open issue?

@Venemo
Copy link
Owner

Venemo commented May 31, 2019

@innerop I've just merged the PR that addresses it. Will push a new release to NPM soon.

@Venemo Venemo reopened this May 31, 2019
@Venemo
Copy link
Owner

Venemo commented Jan 15, 2020

With the release of 0.8.0 on npm, I think this issue can be closed now.

@Venemo Venemo closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V12 upgrade kriszyp/node-lmdb
4 participants
@kriszyp @josephg @Venemo @innerop