Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all custom iterators to adhere to PascalCase naming convention for classes? #312

Open
Adda0 opened this issue Aug 25, 2023 · 0 comments
Labels
For:library The issue is related to library (c++ implementation) Priority:normal Work on this sooner rather than later. Type:discussion A discussion of some particular topic in wider audience

Comments

@Adda0
Copy link
Collaborator

Adda0 commented Aug 25, 2023

We currently implement several custom iterator, all named as const_iterator, and iterator. It was suggested that we should rename them to ConstIterator and Iterator to adhere to our naming convention for classes, PascalCase. Is it possible if we want to keep all the iterator functionality in STL? Does anything expect classes to have exactly const_iterator and iterator types?

This includes Transitions::const_iterator, Moves::const_iterator, OrdVector::const_iterator, SparseSet::iterator, and more.

As far as I can tell, everything we now use should work as it currently does. However, there might be some issues later on, I am not sure about that. After some research, it seems to me that the name should hopefully not be relevant as far as supported functionality goes.

@Adda0 Adda0 added For:library The issue is related to library (c++ implementation) Type:discussion A discussion of some particular topic in wider audience Priority:normal Work on this sooner rather than later. labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For:library The issue is related to library (c++ implementation) Priority:normal Work on this sooner rather than later. Type:discussion A discussion of some particular topic in wider audience
Projects
None yet
Development

No branches or pull requests

1 participant