Create a naming convention for iterator variables

[Adda0]

It was decided that we will name iterator variables as <the_name_of_the_object_we_get_by_dereferencing_the_iterator>_it. We can slowly begin renaming all existing iterator variables to adhere to this convention.

Const variables for iterators returned by begin() and end() methods should be named <the_name_of_the_object_we_get_by_dereferencing_the_iterator>_begin and <the_name_of_the_object_we_get_by_dereferencing_the_iterator>_end, respectively.

For example, for const iterator over StatePost, we get the following variable name:

StatePost::const_iterator symbol_post_it = nfa.delta.state_post(4).begin();
StatePost::const_iterator next_symbol_post_it = ++symbol_post_it;
const StatePost::const_iterator symbol_post_begin = nfa.delta.state_post(4).begin();
assert(next_symbol_post_it != symbol_post_begin);

When using the iterator over a small block of code (e.g., at most 3-line for loop), one can use just it and similar without having to specify the name of the object at all.

Does anyone have any further comments or suggestions?