Expand alphabets #433
Merged
Expand alphabets #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the standard library implementation of erase operations for containers.
jurajsic
reviewed
Aug 21, 2024
jurajsic
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements additional methods for alphabets to allow their copying, erasing symbols and clearing the alphabets, as requested by #426:
clear()method to clear the alphabet (for alphabets where it makes sense),erase()method to erase a specific symbol from the alphabet (for alphabets where it makes sense),To allow erasing, the PR also modifies the return type of
erase()operations forOrdVectorand alphabets to follow the implementation of erase operations in standard library containers, returning the number of erased elements.Fixes #426.