Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code breaks when duckling dimension "Amount-of-money" is used. #58

Closed
nxbringr opened this issue Jun 17, 2021 · 1 comment · Fixed by #62
Closed

Code breaks when duckling dimension "Amount-of-money" is used. #58

nxbringr opened this issue Jun 17, 2021 · 1 comment · Fixed by #62
Labels
bug Something isn't working

Comments

@nxbringr
Copy link

Describe the bug
When using dimensions like "amount-of-money" the code breaks here. There is no support for entities that are not listed here.

To Reproduce
Steps to reproduce the behavior:

  1. Add "amount-of-money" as one of the dimensions in duckling (predict.py file)
  2. Run 'poetry run slu repl'
  3. Enter '300 dollars'
  4. Refer to the screenshot for the error traceback.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
error_ducking

Desktop (please complete the following information):

  • OS: Ubuntu (e2e server)
  • Python version: 3.8.7

@greed2411 @ltbringer

@nxbringr nxbringr added the bug Something isn't working label Jun 17, 2021
@nxbringr nxbringr changed the title Code breaks when duckling diimension "Amount-of-money" is used. Code breaks when duckling dimension "Amount-of-money" is used. Jun 17, 2021
@ltbringer
Copy link
Contributor

Thank you for the report. We didn't have support for this entity, supported entities are here. To add support we need to add a CurrencyEntity It can inherit from NumericalEntity.

This was linked to pull requests Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants