Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--download-browser-driver recurring failure #1098

Closed
lucasgajewski opened this issue Jul 24, 2023 · 4 comments
Closed

--download-browser-driver recurring failure #1098

lucasgajewski opened this issue Jul 24, 2023 · 4 comments

Comments

@lucasgajewski
Copy link

Hi folks,

I've been using saml2aws for a while now, but recently, it broke for me.
Now, when I run the command listed bellow, I get the following error:

$ saml2aws login --force --download-browser-driver
Using IdP Account default to access Browser https://aws-account-address/
To use saved password just hit enter.
? Username me@me.com
? Password **************

Authenticating as me@me.com ...
Downloading driver to /Users/me/Library/Caches/ms-playwright-go/1.20.0-beta-1647057403000
Downloaded driver successfully

/Users/me/Library/Caches/ms-playwright-go/1.20.0-beta-1647057403000/package/lib/cli/cli.js:263
    require(playwrightTestPackagePath).addTestCommand(_commander.program);
                                       ^

TypeError: require(...).addTestCommand is not a function
    at Object.<anonymous> (/Users/me/Library/Caches/ms-playwright-go/1.20.0-beta-1647057403000/package/lib/cli/cli.js:263:40)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47
Error authenticating to IdP.: could not install driver: could not install browsers: could not install browsers: exit status 1

I removed the sensitive bits, but I've confirmed that I'm using the right web address and credentials and such for the AWS bit.

I have tried fully removing and redownloading saml2aws, clearing my node cache, uninstalling node and go, and clearning out the Cache folder that the process is downloading Playwright to.

When I take a look at the /Users/me/Library/Caches/ms-playwright folder, it's empty. I assume that's where we expect the browsers to go.

Any advice is appreciated!

@mapkon
Copy link
Member

mapkon commented Aug 29, 2023

Did you follow the instructions here? #1006

@lucasgajewski
Copy link
Author

lucasgajewski commented Sep 6, 2023

Hey @mapkon, not sure I understand.

It looks like that PR just establishes the use of the --download-browser-driver flag, which I've been using.

This issue shows up both when I use the flag, as well as when I leave it out.

Thanks in advance!

@mikex99
Copy link

mikex99 commented Sep 13, 2023

I'm also seeing this in my environment. Mac with 2.36.10

@lucasgajewski
Copy link
Author

This can be closed out. Updating to 2.36.11 seems to have fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants