Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake include path issue #8

Open
derpda opened this issue Jul 12, 2022 · 3 comments
Open

CMake include path issue #8

derpda opened this issue Jul 12, 2022 · 3 comments

Comments

@derpda
Copy link
Contributor

derpda commented Jul 12, 2022

Once again thank you for putting this together, and for reacting to the issues/PRs so quickly.

Issue

When using this library through

FetchContent_Declare(ByteTrackCpp
  GIT_REPOSITORY  https://github.com/Vertical-Beach/ByteTrack-cpp.git
  GIT_TAG         main
  GIT_SHALLOW     ON)
FetchContent_MakeAvailable(ByteTrackCpp)
# ...
target_link_libraries(my_lib bytetrack)

in my project, the include paths needed for the bytetrack library are not forwarded.
Checking a bit further,

get_target_property(bytetrack_INCLUDE_DIRS bytetrack INTERFACE_INCLUDE_DIRECTORIES)
message(STATUS "ByteTrack include dirs: ${bytetrack_INCLUDE_DIRS}")

shows that INTERFACE_INCLUDE_DIRECTORIES are not set.

I will open another small PR fixing this once the current one is merged!

@derpda derpda mentioned this issue Jul 19, 2022
@medalotte
Copy link
Contributor

medalotte commented Sep 1, 2022

Thanks! No problem, I have merged it.

@medalotte medalotte reopened this Sep 1, 2022
@medalotte
Copy link
Contributor

I made a mistake on the issue to close.

@derpda
Copy link
Contributor Author

derpda commented Sep 5, 2022

Thank you for getting back to me =)
I think this issue is fixed with PR #10!
As mentioned in the PR, I have since made a host of other changes, if you are interested I can post PRs for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants