Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: retry datasource requests for trivial network errors #193

Closed
hagen1778 opened this issue Aug 9, 2024 · 7 comments
Closed

backend: retry datasource requests for trivial network errors #193

hagen1778 opened this issue Aug 9, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@hagen1778
Copy link
Contributor

See VictoriaMetrics/VictoriaMetrics#6712

In the issue above, request sent by Grafana failed because of EOF error. There could be many reasons why plugin faced the EOF error, but the sensible thing to do would be to retry such trivial network errors.

For the reference, other VM components like vmalert already retry requests for such errors.

@dmitryk-dk
Copy link
Contributor

Hi @hagen1778 ! Should we use the exact mechanism in the Victorialogs data source?

@hagen1778
Copy link
Contributor Author

Hi @hagen1778 ! Should we use the exact mechanism in the Victorialogs data source?

Yes

@hagen1778
Copy link
Contributor Author

plugin should retry trivial network errors like "unexpected EOF" or "broken pipe" in #194. This change will be included into the next release.

@hagen1778
Copy link
Contributor Author

@dmitryk-dk can we make release soon?

@dmitryk-dk
Copy link
Contributor

@dmitryk-dk can we make release soon?

Yeah, i think will do it today little bit later

@dmitryk-dk
Copy link
Contributor

Hi @hagen1778 ! Release was published with the latest changes. The fix was included into v0.9.0 release.

@dmitryk-dk
Copy link
Contributor

Hi @hagen1778 ! The same behavior was ported to the victorialogs-datasource in the v0.4.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants