[Issue #2487] Add YouTube share link option below the video #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add YouTube share button * Handle non-HTTPS environment in copy operation
…op. Fix formatting
|
Hi, awesome to have you here! Your code looks great, the only thing I would suggest is to use the ViewTube message system instead of alert(). This will show a dismissible toast on the top right. You can check out an example of how to use the messagesStore in the About.vue component. |
|
Thanks for the hints! I was searching for a |
|
Awesome! @all-contributors add @chonsser for code |
|
I've put up a pull request to add @chonsser! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I'm happy to contribute to this project. I'd love (if time allows) to work more on this project.
In this first PR, I've added a new YouTube share button (solves issue #2487).
Also, based on my own experience (running ViewTube via non-HTTPS environment), I added a code to handle the copy operation on that environment (notifies the user that the copy operation has failed).