Added trending toggle in client settings #2735
Conversation
|
Hi, thanks a lot for your PR! Please give me a moment to check it out |
|
Looks good! I would recommend adding the settings entry to the backend, so it can be synced to the user account. |
|
As for the empty homepage, maybe just show a little icon or something to indicate it hasn't failed loading. Or leave it blank, however you prefer :) |
* Added comments toggle in client settings * hideComments toggle category change --------- Co-authored-by: iyakushev <yakushevis@itsintellect.ru>
Agreed, i think i'll just move the search bar and the logo to the center of the page like Invidious does, if that's ok.
|
|
Thats a cool idea! |
|
Done! Let met know if you see anything odd. |
| @@ -28,7 +27,7 @@ const { posAbsolute, topPositionPx } = useHeaderScroll(); | |||
| left: 0; | |||
| display: flex; | |||
| flex-direction: row; | |||
| justify-content: space-between; | |||
| justify-content: right; | |||
There was a problem hiding this comment.
This was needed because when we hide the Logo and the MainSearchBox, the UserMenu was on the left side of the header bar.
client/components/Logo.vue
Outdated
There was a problem hiding this comment.
I thought that moving the Logo to it's own component would help for any use case outside of the header bar.
|
Thanks a lot, I'll test it aso soon as I can |
|
Looks great, the only thing i noticed is, the search bar and logo doesn't reappear when you are on a different page from the homepage |
oh yes, i forgot about that issue. |
You could maybe recognize the current page by using |
Sorry, i didn't see your message. I just sent a fix, let me know if it's good. |
|
Looks good, the only thing i would change is moving the useRoute into script setup, so it only gets called once |
|
Done! |
|
Looks good to me, I'll merge |
Hi! I've added a toggle in the client settings to disable trending videos in the home screen. Which resolves #2587.
Having both
Show subscriptions on home screenand the newShow trending videos on home screenoff results in an empty page, do we need to do something about this as mentioned in the issue?Do we expand the number of subscriptions videos on the home page when this setting is disabled?