Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2450 search enhancement #2770

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

frozenduck
Copy link
Contributor

This PR adds automatic search execution when you click on an item in the search drop-down list.

#2450

@moisout
Copy link
Member

moisout commented Apr 15, 2024

Thanks a lot for this PR, I'll check it out as soon as i can!

@moisout
Copy link
Member

moisout commented Apr 15, 2024

Awesome, LGTM

@moisout moisout merged commit 355bc9c into ViewTube:development Apr 15, 2024
3 of 5 checks passed
@frozenduck
Copy link
Contributor Author

Thank you, the next task I'd like to work on is
#2152

I'll probably have time at the end of the week.
I would like to know if you have any progress on this issue now ? So that our code doesn't overlap.

@moisout
Copy link
Member

moisout commented Apr 15, 2024

Thank you, the next task I'd like to work on is #2152

I'll probably have time at the end of the week. I would like to know if you have any progress on this issue now ? So that our code doesn't overlap.

I haven't started working on that, feel free to!
I am currently working on:

  • Replacing the comments API (It's why the tests are failing)
  • The new Video Player

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants