Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Set limit for review comment part Frontend + Backend. #383

Closed
3 tasks done
Suvadip-sana opened this issue Nov 5, 2024 · 4 comments
Closed
3 tasks done

Feat: Set limit for review comment part Frontend + Backend. #383

Suvadip-sana opened this issue Nov 5, 2024 · 4 comments

Comments

@Suvadip-sana
Copy link
Contributor

Suvadip-sana commented Nov 5, 2024

Describe the feature

As you can see in the attached video there is no check to protect the large input of review comment part. User can give large review comment as large as possible if they want. Which is not good practice. And also there is no need that much long reviewa for one campsite.

  • So here I would like to introduce a good features that, If one review comment length exceed 150 then it show a Read more anchor tag. After clicking on it, It open a Scrollable model in the middle of he screen to display full length review. Which is also responsive for all screen. Just like this Video.
samplee.mp4
  • And also I add a proper backend logic to prevent the large review comment input in create review route. I set the limit of 600 character, I think this is enough for a review comment. If this limit exceed then it display a error flash message. And redirect to show list route, means that new review added form.

Add ScreenShots

creview.mp4

@Vignesh025 Assign it to me. I think it's that major issue which need attention. Assign it under label-3 because both frontend and backend implementations are there. I think this is fair.

Record

  • I agree to follow this project's Code of Conduct
  • I'm a GSSOC'24 contributor
  • I want to work on this issue
@github-actions github-actions bot added the feature New Feature label Nov 5, 2024
@Vignesh025
Copy link
Contributor

@Suvadip-sana , you can proceed!

@Suvadip-sana
Copy link
Contributor Author

Suvadip-sana commented Nov 5, 2024

@Vignesh025
Is label-1 enough?
It's supposed to be label-2 atleast?

@Vignesh025
Copy link
Contributor

@Suvadip-sana , as you know it's just temporary. we'll change it accordingly after reviewing the PR.

@Suvadip-sana
Copy link
Contributor Author

@Vignesh025
Ok got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants