Skip to content

Commit

Permalink
Update NDK to 26.1 . Raise minSdk to 21 (because of NDK)
Browse files Browse the repository at this point in the history
  • Loading branch information
ViliusSutkus89 committed Jan 1, 2024
1 parent b8b20f8 commit b502e9c
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 16 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,6 @@ jobs:
fail-fast: false
matrix:
include:
# Oldest API supported by NDK
- arch: x86
api-level: 16
api-type-target: default
# Oldest x86_64 image
- arch: x86_64
api-level: 21
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/unprivilegedBuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,6 @@ jobs:
fail-fast: false
matrix:
include:
# Oldest API supported by NDK
- arch: x86
api-level: 16
api-type-target: default
# Oldest x86_64 image
- arch: x86_64
api-level: 21
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ Library needs Android Context to obtain path to cache directory and asset files,

### C++ runtime dependency:
[Using mismatched prebuilt libraries](https://developer.android.com/ndk/guides/common-problems#using_mismatched_prebuilt_libraries) is less problematic if all the libraries used in the application are:
* Built with the same toolchain - ndk-23.2.8568313
* Built with the same toolchain - ndk-26.1.10909125
* Linked against shared C++ STL - `android.defaultConfig.externalNativeBuild.cmake.arguments "-DANDROID_STL=c++_shared"` in app's (and all JNI dependencies) build.gradle.
4 changes: 2 additions & 2 deletions dependency-builder/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ apply plugin: 'com.android.library'
android {
compileSdkVersion 33
defaultConfig {
minSdkVersion 16
minSdkVersion 21
targetSdkVersion 33
ndk.abiFilters = project.hasProperty('abi') ? [project.property('abi')] : ["arm64-v8a", "armeabi-v7a", "x86", "x86_64"]
externalNativeBuild.cmake.arguments '-DANDROID_STL=c++_shared'
Expand All @@ -34,7 +34,7 @@ android {
path "src/main/cpp/CMakeLists.txt"
version "3.22.1"
}
ndkVersion '23.2.8568313'
ndkVersion '26.1.10909125'
}

// Issue #1 (from pdf2htmlEX-Android)
Expand Down
4 changes: 1 addition & 3 deletions doChangeNDK
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ set -eu
THIS_FILE=$(readlink -f "$0")
BASEDIR=$(dirname "$THIS_FILE")

# NDK-23 is the last to support api-16
NDK="23.2.8568313"
#NDK="25.0.8775105"
NDK="26.1.10909125"

version_format='([0-9\.]+)'

Expand Down
4 changes: 2 additions & 2 deletions wvWare/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ afterEvaluate {
android {
compileSdkVersion 33
defaultConfig {
minSdkVersion 16
minSdkVersion 21
targetSdkVersion 33

versionCode 223
Expand All @@ -67,7 +67,7 @@ android {
path "src/main/cpp/CMakeLists.txt"
version "3.22.1"
}
ndkVersion '23.2.8568313'
ndkVersion '26.1.10909125'
buildTypes {
release.externalNativeBuild.cmake.arguments '-DCMAKE_BUILD_TYPE=MinSizeRel', "-DINSTALLED_PREFIX=${gatherReleaseArtifactsTask.installed.get()}"
debug.externalNativeBuild.cmake.arguments "-DINSTALLED_PREFIX=${gatherDebugArtifactsTask.installed.get()}"
Expand Down

0 comments on commit b502e9c

Please sign in to comment.