Feature/ilkka starting time freely & duration time can be set freely too #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
June 26, 2024 15:13
…t to the availableroomlist thru bookingview
…st 100% of the width (durationpicker)
…custom button still missing
… so that custom value is seen as additional button and removed when non-custom value selected
…xes so that these both button groups now work
villepynttari
requested changes
Jul 9, 2024
frontend/src/components/DurationTimePickerDrawer/DurationTimePickerDrawer.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/StartingTimePickerDrawer/StartingTimePickerDrawer.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/StartingTimePickerDrawer/StartingTimePickerDrawer.tsx
Show resolved
Hide resolved
frontend/src/components/DurationTimePickerDrawer/DurationTimePickerDrawer.tsx
Outdated
Show resolved
Hide resolved
JBergVincit
reviewed
Jul 9, 2024
frontend/src/components/AvailableRoomList/AvailableRoomList.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/DurationTimePickerDrawer/DurationTimePickerDrawer.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/DurationTimePickerDrawer/DurationTimePickerDrawer.tsx
Outdated
Show resolved
Hide resolved
| setStartingTime, | ||
| setExpandTimePickerDrawer | ||
| } = props; | ||
| const [time, setTime] = useState<string>(DateTime.now().toFormat('HH:mm')); |
There was a problem hiding this comment.
Olisiko tässä tapauksessa mahdollista hoitaa jotenkin StartingTimePickerDrawerin sisäinen aikaleimojen käsittely DateTime (tai Date) muodossa, ja vasta "setStartingTime"ä kutsuttaessa muuttaa aikaleima string muotoiseksi? Voisi selvitä vähemmällä string muotoisten aikalaiemojen käsittelyllä ja saattaisi helpottaa vertailuoperaatioita jne.
There was a problem hiding this comment.
katson myöhemmin refaktoroinnin yhteydessä helpottaisiko se, teen toisen pr:n siitä
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature/ilkka starting time freely & duration time can be set freely too
in this feature branch there are 2 features (my mistake but does it matter...)
user can select starting time by custom button
and also duration
tests are missing and some minor stuff but I make a separate pr for those