Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geom_hline, geom_vline #139

Open
Vindaar opened this issue Dec 1, 2021 · 3 comments
Open

Add geom_hline, geom_vline #139

Vindaar opened this issue Dec 1, 2021 · 3 comments

Comments

@Vindaar
Copy link
Owner

Vindaar commented Dec 1, 2021

While these can be easily done via geom_linerange, it's easier and more intuitive to support these. Implementation should be straightforward.

On the implementation side we should probably do it by adding an additional trivial dataframe, to avoid the "overdrawing" that currently happens for geom_linerange if it's being used for this purpose.

@pietroppeter
Copy link

I could give it a try implementing this and learn a bit more about internals of ggplotnim 😃

@Vindaar
Copy link
Owner Author

Vindaar commented Dec 1, 2021

If you would like to learn about that, I'm not going to stop you. ;)

What I mentioned in the issue should really be all that is required. This implies that one should only have to add the geom_h/vline procs in ggplotnim.nim and as long as one creates the correct return value, everything should already work. No additional things required, I believe. While doing this the kind field of the returned returned Geom should just be set to gkLine and a trivial data frame is given for the optional data field.

Just keep in mind that adding a recipe can be quite annoying.

If you want to give it a try, feel free to ping me on matrix / discord of course.

@pietroppeter
Copy link

feel free to ping me on matrix / discord of course

You see I am not shy about that :)

Already have great pointers there!

Will definitely try, not sure when I will manage to squeeze it, could be this weekend could be after Christmas ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants