Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] socks5 proxy #15

Open
wanghaisheng opened this issue Jun 6, 2023 · 9 comments
Open

[BUG] socks5 proxy #15

wanghaisheng opened this issue Jun 6, 2023 · 9 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@wanghaisheng
Copy link

Describe the bug

  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/tsup-0.1.16-py3.9.egg/tsup/botright/botright.py", line 26, in new_browser
    _proxy = await ProxyManager(self, proxy)
  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/async_class.py", line 173, in __await__
    yield from self.create_task(
  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/tsup-0.1.16-py3.9.egg/tsup/botright/modules/proxy_manager.py", line 28, in __ainit__
    self.split_proxy()
  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/tsup-0.1.16-py3.9.egg/tsup/botright/modules/proxy_manager.py", line 68, in split_proxy
    raise SplitError(f"Proxy Format ({self.proxy}) isnt supported")
tsup.botright.modules.proxy_manager.SplitError: Proxy Format (socks5://127.0.0.1:1080) isnt supported

Code Sample
If applicable, add a code sample to replicate the bug.

To Reproduce

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@wanghaisheng wanghaisheng added bug Something isn't working help wanted Extra attention is needed labels Jun 6, 2023
@gryffus
Copy link

gryffus commented Aug 25, 2024

Do I understand it correctly, that there is currently no way to get SOCKS5 working with botright?

@wanghaisheng
Copy link
Author

i can say last i try is failure, currently i have no idea

@gryffus
Copy link

gryffus commented Aug 25, 2024

Why did you close it, then? 🤣
@wanghaisheng

@gryffus
Copy link

gryffus commented Aug 31, 2024

@wanghaisheng can you please reopen the issue? It's not solved yet. Thanks.

@wanghaisheng
Copy link
Author

@gryffus why bother that? for a year without any response

@gryffus
Copy link

gryffus commented Aug 31, 2024

This is not how development works. The author does this in his free time and does not "owe" you any fixes or implementation. Not even communication.

Regardless, the issue is still existing and thus there is no reason to close it yet. "It takes too long" is not a reason for closing an issue.

If you want it implemented sooner, just sponsor the project and I am sure it will get through :).

@gryffus
Copy link

gryffus commented Aug 31, 2024

Please reopen the issue. Thanks @wanghaisheng

@Vinyzu Vinyzu reopened this Aug 31, 2024
@Vinyzu
Copy link
Owner

Vinyzu commented Aug 31, 2024

Issue will be worked on (someday).

@gryffus
Copy link

gryffus commented Sep 1, 2024

Thanks @Vinyzu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants