-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the SonarCloud issues in IForwardSover #102
Comments
Thanks for working on this! |
Can you describe how they are currently organized, what the code issues are, and how you plan to change it? |
Overloads of methods are supposed to be organized together in a class, We are updating the XML comments with what previously were comments in the file and putting the methods together. Once it is complete, I will make sure you are both included in the PR so you can comment on the changes. |
@dcuccia I wanted to give you a chance to review this before we merge since you had asked how it would be implemented. Let me know if you have time to review. |
The IForwardSolver interface is not correctly organized and as a result, it causes code issues. When this file is inherited these issues are duplicated in the new class.
Fix the organization in the main file and then in the classes that inherit IForwardSolver.
The text was updated successfully, but these errors were encountered: