Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the SonarCloud issues in IForwardSover #102

Closed
lmalenfant opened this issue Sep 29, 2023 · 4 comments · Fixed by #104
Closed

Fix the SonarCloud issues in IForwardSover #102

lmalenfant opened this issue Sep 29, 2023 · 4 comments · Fixed by #104
Assignees

Comments

@lmalenfant
Copy link
Member

The IForwardSolver interface is not correctly organized and as a result, it causes code issues. When this file is inherited these issues are duplicated in the new class.

Fix the organization in the main file and then in the classes that inherit IForwardSolver.

@lmalenfant lmalenfant self-assigned this Sep 29, 2023
@hayakawa16
Copy link
Member

Thanks for working on this!

@dcuccia
Copy link
Contributor

dcuccia commented Sep 29, 2023

Can you describe how they are currently organized, what the code issues are, and how you plan to change it?

@lmalenfant
Copy link
Member Author

Can you describe how they are currently organized, what the code issues are, and how you plan to change it?

Overloads of methods are supposed to be organized together in a class, We are updating the XML comments with what previously were comments in the file and putting the methods together.

Once it is complete, I will make sure you are both included in the PR so you can comment on the changes.

@lmalenfant lmalenfant linked a pull request Sep 30, 2023 that will close this issue
@lmalenfant
Copy link
Member Author

@dcuccia I wanted to give you a chance to review this before we merge since you had asked how it would be implemented. Let me know if you have time to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants