Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in 2 of the Detectors TransmittedMTOfXAndYAndSubregionHistDetector and ReflectedMTOfXAndYAndSubregionHistDetector #115

Closed
lmalenfant opened this issue Oct 10, 2023 · 2 comments · Fixed by #119
Assignees

Comments

@lmalenfant
Copy link
Member

Describe the bug
While looking though the serialization code to research the reconfiguration, I discovered a bug in two of the detectors. This could result in the wrong information being serialized or it could cause an exception if the data does not align.

Application (MCCL, MATLAB or VTS code):
VTS Code

Bug Locations
VTS\src\Vts\MonteCarlo\Detectors
File: TransmittedMTOfXAndYAndSubregionHistDetector.cs at line 342, this value should be Y
File: ReflectedMTOfXAndYAndSubregionHistDetector.cs at line 345, this value should be Y

Additional context
This should be fixed as a hotfix before the next release because it could produce unexpected results.

@lmalenfant
Copy link
Member Author

@hayakawa16 could you update the unit tests for these detectors so in future if there was a bug, they would fail.

@hayakawa16
Copy link
Member

Unit tests updated and run successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants