Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests that compare output strings do not work on Linux #163

Closed
hayakawa16 opened this issue Aug 23, 2024 · 0 comments · Fixed by #164
Closed

Unit tests that compare output strings do not work on Linux #163

hayakawa16 opened this issue Aug 23, 2024 · 0 comments · Fixed by #164
Assignees
@hayakawa16

Comments

@hayakawa16
Copy link
Member

String endings different on Windows (\r\n) vs Linux(\n). Any unit tests that verify an output string with these ending characters are not passing on Linux.

Proposed correction: Modify any "ToString()" used in unit tests to "ToString().Trim()" and remove "\r\n" from verifying string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hayakawa16 hayakawa16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modified string comparision to add "Trim()" so that tests work on bot… VirtualPhotonics/VTS
1 participant
@hayakawa16